-
Notifications
You must be signed in to change notification settings - Fork 44
Add github action #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for your PR! (we'd better work this way)
There are some changes that aren't really needed, take a look at what https://github.com/nix-community/nixos-images already does.
Could you please change PR to merge into the develop and squash commits for the sake of better maintainability in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This additional configuration isn't needed.
This flake uses https://github.com/nix-community/nixos-images as a base for installer images:
- ssh is already enabled, permitting password logins
- root can login with the dynamically-generated password show on the screen
|
ah, thank you! I am going to put this on draft, as I do need to fix up the action :) |
|
I'm gonna make my own PR. This one isn't great. |
This makes 2 changes:
passwordon the nixos account (to make initial setup easier)If you want me to take out the password part but keep the action lmk. Also feel free to copy pasta the action :)