ioctl: nvme_get_features use nvme_passthru_cmd directly #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Wagner <[email protected]>
The next change will add a static inline implementation of nvme_get_log which uses nvme_get_log_page. Thus move the nvme_get_log_page function up so it can be used directly. Signed-off-by: Daniel Wagner <[email protected]>
Refactor nvme_get_log and nvme_get_log_page to use use struct nvme_passthru_cmd directly and drop the struct nvme_get_log_args. The struct args have are ABI thus it's hard to change it after a release. The nvme_passthru_cmd buffer is a generic buffer and it's possible to use the setters directly on the buffer in an inline function. Besides a reduced API to maintain it also generates better code and avoids one call less when issue a command. Signed-off-by: Daniel Wagner <[email protected]> merge with: 532c209 ("ioctl: nvme_get_log use nvme_passthru_cmd directly")
The compiler warns with
../test/ioctl/logs.c: In function ‘test_get_log_reachability_groups’:
../test/ioctl/logs.c:725:28: warning: enum constant in boolean context [-Wint-in-bool-context]
725 | (!!TEST_LSP << 8) | (!!TEST_RAE << 15) |
| ^
../test/ioctl/logs.c:733:70: warning: enum constant in boolean context [-Wint-in-bool-context]
733 | err = nvme_get_log_reachability_groups(test_link, TEST_RAE, !!TEST_LSP,
| ^
Update the tests so the types are correctly handled. It also addresses
the problem with the wrong lsp value testing.
Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_format_nvm_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_ns_mgmt_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_ns_attach_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_fw_download_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_fw_commit_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_security_send_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_set_features_args. Signed-off-by: Dennis Maisenbacher <[email protected]>
Drop struct nvme_dsm_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_io_args. Signed-off-by: Tokunori Ikegami <[email protected]> ioctl: reorder nsid argument Also order the pointer and its length member go to the end of the list. Signed-off-by: Tokunori Ikegami <[email protected]>
To use the fields in nvme_io() and nvme_dsm() functions. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_copy_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_resv_acquire_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_resv_register_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_resv_release_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_resv_report_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_io_mgmt_recv_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_io_mgmt_send_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_zns_mgmt_send_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_zns_mgmt_recv_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_zns_append_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_dim_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Since the warning message output by kernel-doc-check. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_get_features_args. Signed-off-by: Dennis Maisenbacher <[email protected]>
|
I've merged this PR directly into libnvme2. Thanks! |
|
Sorry @MaisenbacherD I've dropped your patch because @ikegami-t had many more changes which I could apply directly. Otherwise the merging would have been too much of an hassle. |
|
oh i screwed up in the merge... |
|
and your patch is back in the queue. I've just got very confused. |
Author
|
Sorry for the delay. Finally catching up with my inbox. Should I rebase this PR again? :) |
|
All good, I've added the patch to the queue. I am going through all the API updating patches and fixup the ordering and missing arguments. Started to create issues to things to work on later. Basically everything which doesn't break the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop struct nvme_get_features_args.