Python: rework nvme_get_Log commands #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the struct args approach by providing init function for initializing the passthru commands. This reduces the dependency between callside and library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Replace the struct args approach by providing init function for initializing the passthru commands. This reduces the dependency between callside and library. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Author
|
Changes for the libnvme3 build error below. [76/110] Compiling C object libnvme/_nvme.cpython-313-x86_64-linux-gnu.so.p/meson-generated_.._nvme_wrap.c.o
FAILED: libnvme/_nvme.cpython-313-x86_64-linux-gnu.so.p/meson-generated_.._nvme_wrap.c.o
cc -Ilibnvme/_nvme.cpython-313-x86_64-linux-gnu.so.p -Ilibnvme -I../libnvme -I. -I.. -Iccan -I../ccan -Isrc -I../src -Iinternal -I../internal -I/usr/include/json-c -I/usr/include/python3.13 -I/usr/include/x86_64-linux-gnu/python3.13 -fvisibility=hidden -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -O2 -g -fomit-frame-pointer -D_GNU_SOURCE -fPIC -MD -MQ libnvme/_nvme.cpython-313-x86_64-linux-gnu.so.p/meson-generated_.._nvme_wrap.c.o -MF libnvme/_nvme.cpython-313-x86_64-linux-gnu.so.p/meson-generated_.._nvme_wrap.c.o.d -o libnvme/_nvme.cpython-313-x86_64-linux-gnu.so.p/meson-generated_.._nvme_wrap.c.o -c libnvme/nvme_wrap.c
libnvme/nvme_wrap.c: In function ‘nvme_ctrl_supported_log_pages’:
libnvme/nvme_wrap.c:3844:27: error: implicit declaration of function ‘nvme_get_log_supported_log_pages’; did you mean ‘nvme_ctrl_supported_log_pages’? [-Wimplicit-function-declaration]
3844 | ret = nvme_get_log_supported_log_pages(nvme_ctrl_get_transport_handle(self), rae, &log);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| nvme_ctrl_supported_log_pages |
|
ah okay, I'll look into it tomorrow. Running out of steam for today. |
|
I've added your patch the nvme_get_log patch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the struct args approach by providing init function for initializing the passthru commands. This reduces the dependency between callside and library.