Fix timeline semaphore leak crash #185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the parameters passed to InitVulkanDecoderDevice() from the applications. There was a change that added a codec to the InitVulkanDecoderDevice() but did not update all of the clients. Signed-off-by: Tony Zlatinski <tzlatinski@nvidia.com>
During sequence reconfiguration (e.g., resolution change), the NvPerFrameDecodeImageSet::init() function was unconditionally creating new timeline semaphores without checking if they already existed. This caused two problems: 1. Memory leak: Old semaphores were never destroyed (the 8 allocations / 1456 bytes leak seen in debug builds) 2. Synchronization corruption: In-flight GPU work was still waiting on the OLD semaphore values, but the NEW semaphores started at initialValue=0. This caused device lost when using display presentation, because the swap chain consumer was using the corrupted timeline synchronization. Headless mode (--noPresent) was unaffected because timeline semaphores are not used for presentation synchronization in that path. Fix: Only create the timeline semaphores if they don't already exist. On reconfigure, reuse the existing semaphores to preserve in-flight synchronization state. Signed-off-by: Tony Zlatinski <tzlatinski@nvidia.com>
Contributor
|
The fix to avoid re-creating the semaphores looks good to me. I see that this PR also contains the changes from #184, but I'm not aware of any connection between these changes. Is there something I'm missing when reviewing this change? Or did that change get included here accidentally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.