Skip to content

Conversation

@hendrikgit
Copy link
Contributor

I added no special env var value to mean "all", one can just set it to the maximum instead I figured. 2 million characters should be enough for anyone.

@hendrikgit hendrikgit force-pushed the tweak-char-sort-limit branch from be9be8d to 12aa12f Compare January 9, 2026 17:33
@Daztek
Copy link
Member

Daztek commented Jan 24, 2026

I think this will 'break' the plugin for people who are already using it by only sorting 1 character? Maybe keep NWNX_TWEAKS_CHARLIST_SORT_BY_LAST_PLAYED_DATE as true/false to enable the tweak and add an additional env var to set the num characters to sort and default to max when it's not set?

@hendrikgit
Copy link
Contributor Author

Yes, those who currently have it set to true would then only get 1 recently used character. I was thinking since the plugin is relatively new maybe we can get away with a small breaking change and keep the code simpler. Seeing how the breaking behaviour is also not that bad.

If you prefer I'll add the second env var, sounds like a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants