[token refresh] Compatibility with python “idan/oauthlib”

[dodikk]

Library site : https://oauthlib.readthedocs.org/en/latest/

Fixed issues :

1. OAuth token refresh lacks "Authorization" header required by "idan/oauthlib"
2. OAuth token is not updated in account store after refresh
3. Client code is not notified about refresh events

[bmctigue]

When will this be merged? I really need the token refresh to be working correctly!

[toto]

Sorry for the late response. This is quite a big PR. Do you think you could just extract one for the refresh token fix?

• I'm not sure about NXApplication
• Fixes like NS_DESIGNATED_INITIALIZER are welcome, but should be done in a seperate PR.
• Constants should not be in the PCH. The PCH should not be touched at at. Better put them into the umbrella header

[dodikk]

Do you think you could just extract one for the refresh token fix?

I think, yes I can. Not sure when I'll have a chance (and some free time).

P.S. Actually, I have created separate pull requests for other improvements. Since they have been ignored, this one looks huge.
#155
#163

[dodikk]

@bmctigue you can take a look at the patched repo where I've implemented a fix. https://github.com/healthjoy-ios-opensource/OAuth2Client

[dodikk]

Do you think you could just extract one for the refresh token fix?

@toto , the mentioned changes start from the commit below healthjoy-ios-opensource@767eada

[dodikk]

Constants should not be in the PCH. The PCH should not be touched at at. Better put them into the umbrella header

Isn't it private stuff that should not be touched by the end user? What's wrong about rarely changed own headers in *.pch ?

Yoda-style comparisons? This should be if (accountType != nil)

Yoda statements are safer and help to avoid if (accountType = nil) typos.

Also the code style is not GNU-style but KR-C so the { goes after the if or else
No paces between arguments and values as well

Come on. Does it all really matter? Are you serious about rejecting the patch due to minor code style incompatibilities?
P.S. Your "Contributing & Pull Requests" readme section lacks a codestyle reference and instructions.

[toto]

Nope, not rejecting the patch, just trying to keep the code style consistent.

Good point regarding the code style in the docs. I will add that.

[dodikk]

Do you think you could just extract one for the refresh token fix?

Done. #174