fix: handle proxyRes error in upgrade

ronag · ronag · commit d53768618be2 · 2017-09-12T12:28:32.000+02:00
diff --git a/index.js b/index.js
@@ -240,8 +240,9 @@ function proxy (req, resOrSocket, options, onRes, onError) {
             .join('\r\n') + '\r\n\r\n'
         )
 
-        // XXX Do we need to handle `proxyRes.on('error', ...)`?
+        // XXX Does this overlap socket errors, i.e. duplicate emits?
         // (https://github.com/nodejs/node/issues/15360)
+        proxyRes.on('error', callback)
 
         proxySocket
           .on('error', callback)

Original file line number	Diff line number	Diff line change
`@@ -240,8 +240,9 @@ function proxy (req, resOrSocket, options, onRes, onError) {`
`240`	`240`	`.join('\r\n') + '\r\n\r\n'`
`241`	`241`	`)`
`242`	`242`
`243`		- // XXX Do we need to handle `proxyRes.on('error', ...)`?
	`243`	`+ // XXX Does this overlap socket errors, i.e. duplicate emits?`
`244`	`244`	`// (https://github.com/nodejs/node/issues/15360)`
	`245`	`+ proxyRes.on('error', callback)`
`245`	`246`
`246`	`247`	`proxySocket`
`247`	`248`	`.on('error', callback)`