Skip to content

Remove ocr duplication#1

Open
aliut wants to merge 38 commits intonyakang:ocrfrom
aliut:patch-1
Open

Remove ocr duplication#1
aliut wants to merge 38 commits intonyakang:ocrfrom
aliut:patch-1

Conversation

@aliut
Copy link
Copy Markdown

@aliut aliut commented Jul 3, 2025

fixed : OCR had been declared twice.

Description

Fixes # (issue)

How Has This Been Tested?

  • Test A
  • Test B

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Summary by cubic

Removed a duplicate OCR job declaration from the fetch-client code to prevent confusion and maintain consistency.

nyakang and others added 30 commits June 1, 2025 22:10
…ation and unwarping options, update PaddleOCR integration, and improve response structure
…date asset job status and schema to accommodate new OCR table structure
…dual coordinates instead of bounding box, and adjust related service and repository files
# Conflicts:
#	mobile/openapi/lib/api.dart
#	mobile/openapi/lib/api_client.dart
- Updated OCR settings to include minimum detection box score, minimum detection score, and minimum recognition score.
- Refactored PaddleOCRecognizer to utilize new scoring parameters.
- Introduced new database tables for asset OCR data and search functionality.
- Modified related services and repositories to support the new OCR features.
- Updated translations for improved clarity in settings UI.
# Conflicts:
#	mobile/openapi/lib/api.dart
#	mobile/openapi/lib/api_client.dart
# Conflicts:
#	machine-learning/uv.lock
#	mobile/openapi/lib/api.dart
#	mobile/openapi/lib/api/search_api.dart
#	mobile/openapi/lib/api_client.dart
#	server/src/controllers/search.controller.ts
# Conflicts:
#	i18n/zh_SIMPLIFIED.json
#	mobile/openapi/lib/api.dart
#	mobile/openapi/lib/api_client.dart
#	web/src/lib/components/shared-components/search-bar/search-bar.svelte
…ation and unwarping options, update PaddleOCR integration, and improve response structure
…date asset job status and schema to accommodate new OCR table structure
…dual coordinates instead of bounding box, and adjust related service and repository files
- Updated OCR settings to include minimum detection box score, minimum detection score, and minimum recognition score.
- Refactored PaddleOCRecognizer to utilize new scoring parameters.
- Introduced new database tables for asset OCR data and search functionality.
- Modified related services and repositories to support the new OCR features.
- Updated translations for improved clarity in settings UI.
mertalev and others added 8 commits June 16, 2025 14:15
fix max resolution key

set min threshold to 0.1

fix bind
# Conflicts:
#	i18n/en.json
# Conflicts:
#	i18n/en.json
#	i18n/zh_SIMPLIFIED.json
#	machine-learning/immich_ml/models/__init__.py
#	machine-learning/immich_ml/schemas.py
#	machine-learning/pyproject.toml
#	machine-learning/uv.lock
#	mobile/openapi/README.md
#	mobile/openapi/lib/api.dart
#	mobile/openapi/lib/api_client.dart
#	open-api/immich-openapi-specs.json
#	server/src/config.ts
#	server/src/controllers/search.controller.ts
#	server/src/db.d.ts
#	server/src/dtos/model-config.dto.ts
#	server/src/repositories/asset-job.repository.ts
#	server/src/repositories/machine-learning.repository.ts
#	server/src/repositories/ocr.repository.ts
#	server/src/repositories/search.repository.ts
#	server/src/schema/tables/asset-ocr.table.ts
#	server/src/schema/tables/ocr-search.table.ts
#	server/src/services/ocr.service.ts
#	web/src/lib/components/admin-page/settings/machine-learning-settings/machine-learning-settings.svelte
#	web/src/lib/components/shared-components/search-bar/search-bar.svelte
fixed : OCR had been declared twice.
@mertalev mertalev force-pushed the ocr branch 2 times, most recently from 3166f26 to 585d093 Compare September 8, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants