Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/meshapi/tests/test_map_endpoints.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import datetime
import json
import uuid
from unittest.mock import patch

import requests_mock
from django.test import Client, TestCase
Expand Down Expand Up @@ -1726,6 +1727,23 @@ def test_kiosk_list_good_state(self, city_api_call_request_mocker):
)
self.assertEqual(len(json.loads(response.content.decode("UTF8"))), 7)

@patch("logging.warning")
@requests_mock.Mocker()
def test_kiosk_list_empty_row(self, mock_warning, city_api_call_request_mocker):
# On 02-07-2025, City of New York LinkNYC API changed its data, and Row 19
# was blank. This tests a guard I added to ensure that doesn't cause us to
# raise Exceptions
city_api_call_request_mocker.get(LINKNYC_KIOSK_DATA_URL, json=[{}])

response = self.c.get("/api/v1/mapdata/kiosks/")
self.assertEqual(
200,
response.status_code,
f"status code incorrect, should be 200, but got {response.status_code}",
)
mock_warning.assert_called()
self.assertEqual(len(json.loads(response.content.decode("UTF8"))), 0)

@requests_mock.Mocker()
def test_kiosk_list_bad_fetch(self, city_api_call_request_mocker):
city_api_call_request_mocker.get(LINKNYC_KIOSK_DATA_URL, status_code=500)
Expand Down
5 changes: 5 additions & 0 deletions src/meshapi/views/map.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,11 @@ def get(self, request: Request) -> Response:

kiosks = []
for row in data:
if not row:
logging.warning(
"Got empty row from City of New York LinkNYC kiosk dataset. Skipping row and moving on."
)
continue
coordinates = [float(row["longitude"]), float(row["latitude"])]
kiosk_status = LINKNYC_KIOSK_STATUS_TRANSLATION.get(row["link_installation_status"])
kiosks.append(
Expand Down
Loading