Skip to content

Additional GPP-382 and GPP-383 Changes#117

Open
johnyu95 wants to merge 4 commits intodevelopfrom
feature/GPP-383
Open

Additional GPP-382 and GPP-383 Changes#117
johnyu95 wants to merge 4 commits intodevelopfrom
feature/GPP-383

Conversation

@johnyu95
Copy link
Copy Markdown
Contributor

Additional 508 changes based on Walei and Arthur's latest feedback

Changes made:

  • Switched position of "Limit your search" heading and button to expand filters (this is intended for mobile view of page).
  • Changed label of button to expand filters from "Toggle Facets" to "Filters".
  • Changed focus outline for homepage link, language picker, and login button to white for better visibility.
  • Changed color of "Go" button for better visibility with the focus outline.
  • Changed "More Options" button into just a link styled as a button instead of a link inside of a button. This is to remove extra tabbing after focus is already on the button.
  • Removed tabindex attribute from skip to link to remove extra tabbing and removed name attribute because it is deprecated.

@johnyu95 johnyu95 requested a review from zgary June 16, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants