Skip to content

fix: prevent title from being passed to the button element #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nygardk merged 1 commit into from
Feb 2, 2025
+7 −0
Merged

fix: prevent title from being passed to the button element #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-horses-enjoy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-share": patch
---

The `title` prop is no longer passed to the `button` element, which may have caused e.g. warnings in the console before. Note that to set the native `title` attribute for the share buttons, you may use the `htmlTitle` prop.
2 changes: 2 additions & 0 deletions src/ShareButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ export default function ShareButton<LinkOptions extends Record<string, unknown>>
opts,
resetButtonStyle = true,
style,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
title, // deconstructed from ...rest to prevent passing it to the button element
url,
windowHeight = 400,
windowPosition = 'windowCenter',
Expand Down