Skip to content

Conversation

@AaronDDM
Copy link
Collaborator

@AaronDDM AaronDDM commented Apr 7, 2025

What did you do?

  • Added support for Notetaker APIs
  • Added support for Notetaker via the calendar and event APIs

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (18)
  • src/main/kotlin/com/nylas/models/Calendar.kt: Language not supported
  • src/main/kotlin/com/nylas/models/CalendarNotetaker.kt: Language not supported
  • src/main/kotlin/com/nylas/models/CreateCalendarRequest.kt: Language not supported
  • src/main/kotlin/com/nylas/models/CreateEventRequest.kt: Language not supported
  • src/main/kotlin/com/nylas/models/CreateNotetakerRequest.kt: Language not supported
  • src/main/kotlin/com/nylas/models/Event.kt: Language not supported
  • src/main/kotlin/com/nylas/models/EventNotetaker.kt: Language not supported
  • src/main/kotlin/com/nylas/models/ListNotetakersQueryParams.kt: Language not supported
  • src/main/kotlin/com/nylas/models/Notetaker.kt: Language not supported
  • src/main/kotlin/com/nylas/models/UpdateCalendarRequest.kt: Language not supported
  • src/main/kotlin/com/nylas/models/UpdateEventRequest.kt: Language not supported
  • src/main/kotlin/com/nylas/models/UpdateNotetakerRequest.kt: Language not supported
  • src/main/kotlin/com/nylas/resources/Notetakers.kt: Language not supported
  • src/test/kotlin/com/nylas/models/CalendarNotetakerTest.kt: Language not supported
  • src/test/kotlin/com/nylas/models/EventNotetakerTest.kt: Language not supported
  • src/test/kotlin/com/nylas/resources/CalendarsTest.kt: Language not supported
  • src/test/kotlin/com/nylas/resources/EventsTests.kt: Language not supported
  • src/test/kotlin/com/nylas/resources/NotetakersTests.kt: Language not supported
Comments suppressed due to low confidence (1)

CHANGELOG.md:5

  • [nitpick] Consider using consistent case for 'Notetaker' across both changelog entries. For clarity, update 'notetaker' to 'Notetaker' in this line.
+* Added support for notetaker via the calendar and event APIs

@AaronDDM AaronDDM changed the title Added support for Nylas Notetaker feat: Added support for Nylas Notetaker Apr 7, 2025
@AaronDDM AaronDDM force-pushed the NOTE-204-notetaker-v-1-endpoints-java-sdk branch from a27d60b to 86b626f Compare April 7, 2025 17:39
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (0a0a738) to head (8f3ff77).

Files with missing lines Patch % Lines
src/main/kotlin/com/nylas/resources/Notetakers.kt 65.11% 8 Missing and 7 partials ⚠️
src/main/kotlin/com/nylas/NylasClient.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #269      +/-   ##
============================================
- Coverage     81.34%   80.57%   -0.77%     
- Complexity      318      333      +15     
============================================
  Files            35       36       +1     
  Lines           970     1014      +44     
  Branches         88       88              
============================================
+ Hits            789      817      +28     
- Misses          129      138       +9     
- Partials         52       59       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AaronDDM AaronDDM requested a review from kraju3 April 7, 2025 18:10
@AaronDDM AaronDDM merged commit 4d776a5 into main Apr 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants