Merged
Conversation
Co-authored-by: aaron.d <aaron.d@nylas.com>
|
Cursor Agent can help with this pull request. Just |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 37 37
Lines 812 812
Branches 72 72
=======================================
Hits 783 783
Misses 26 26
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nylas + PlayerZeroSimulations
Results
|
samuelpx
approved these changes
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: make conferencing property optional in Event model
Closes #678
The
conferencingproperty in theEventinterface was incorrectly marked as required, leading to issues when handling events without conferencing details from the API.This PR makes the
conferencingproperty optional (conferencing?: Conferencing;) insrc/models/events.tsto align with the actual API behavior.New tests have been added in
tests/resources/events.spec.tsto verify that events can be correctly handled and created both with and without conferencing information. TheCHANGELOG.mdhas also been updated.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.