raise an explicit exception when response does not include a JSON body #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDDM
approved these changes
Apr 9, 2025
Contributor
Author
|
@AaronDDM Rubocop seems to be failing, but I'm not entirely sure why. The files it mentions that are causing failures were not touched in this PR. |
Contributor
Can you rebase with the base branch? I think I fixed this issue. |
There should be no reason for the API to respond with a `200 OK` and an empty body, however, sometimes that has happened to us, resulting in this exception: ``` NoMethodError: undefined method `[]' for nil ``` This comes from: * `nylas/handler/api_operations.rb` in `get_list` at line `34` * `nylas/resources/messages.rb` in `list` at line `31` Instead of raising a `NoMethodError` when trying to access `response`, `parse_response` now explicitly checks that it's returning *something*.
agrobbin
force-pushed
the
handle-successful-response-missing-body
branch
from
d9eb509 to
0eb658f
Compare
Contributor
Author
|
@AaronDDM done! |
Contributor
Author
|
Thanks so much @AaronDDM! Looking forward to this getting included in the next release. |
Contributor
If all goes well, the next release will be next week. Thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There should be no reason for the API to respond with a
200 OKand an empty body, however, sometimes that has happened to us, resulting in this exception:This comes from:
nylas/handler/api_operations.rbinget_listat line34nylas/resources/messages.rbinlistat line31Instead of raising a
NoMethodErrorwhen trying to accessresponse,parse_responsenow explicitly checks that it's returning something.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.