Skip to content

feat: add config settings to support PR #72#73

Open
Kashkin wants to merge 1 commit intonystudio107:developfrom
Kashkin:develop
Open

feat: add config settings to support PR #72#73
Kashkin wants to merge 1 commit intonystudio107:developfrom
Kashkin:develop

Conversation

@Kashkin
Copy link

@Kashkin Kashkin commented Sep 6, 2023

Description

All of the actual work is over in craft-plugin-vite!

@Kashkin Kashkin requested a review from khalwat as a code owner September 6, 2023 05:13
@khalwat
Copy link
Contributor

khalwat commented Sep 17, 2023

Thanks for the PR! A few comments:

  • I wonder if we can just use the manifestPath here rather than add a new dist property? They will both always point to the same thing, and we can just strip the manifest.json off of it, and things will "just work" without people needing to reconfigure anything or adding a mostly redundant additional config setting.

(In retrospect, it would have made sense from the beginning to have just a dist property, and determine the manifest from there but... alas that ship has sailed).

  • This plugin has both a Craft v3 and a Craft v4 version, so I'll need to port any changes to develop to develop-v4 also, or you can do dual PRs

  • The documentation needs to be updated for both Craft v3 and Craft v4

I'm happy to do the latter 2 bullet points, but want to figure out the first one before proceeding

@Kashkin
Copy link
Author

Kashkin commented Sep 17, 2023

I wonder if we can just use the manifestPath here rather than add a new dist property? They will both always point to the same thing, and we can just strip the manifest.json off of it, and things will "just work" without people needing to reconfigure anything or adding a mostly redundant additional config setting.

Stripping manifestPath makes sense to me! The new config does seem a bit redundant (isn't hindsight a bastard) and the impact will be minimal, as it only affects people using this new option!

@khalwat
Copy link
Contributor

khalwat commented Sep 18, 2023

Do you want to make the changes to the PR? You have a test case that you can confirm works, ya?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants