Skip to content

Conversation

@nyurik
Copy link
Owner

@nyurik nyurik commented Dec 14, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 14, 2025 07:39
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (b30aa97) to head (b192ef6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files           3        3           
  Lines          78       78           
  Branches       78       78           
=======================================
  Hits           70       70           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nyurik nyurik merged commit 10dac98 into main Dec 14, 2025
13 checks passed
@nyurik nyurik deleted the editorconfig branch December 14, 2025 07:41
@nyurik nyurik mentioned this pull request Dec 14, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the repository's code quality infrastructure by adding comprehensive EditorConfig settings and performing minor maintenance cleanups. The changes standardize formatting rules across different file types and simplify MSRV (Minimum Supported Rust Version) testing procedures.

Key changes:

  • Added detailed .editorconfig with file-type-specific indentation rules (2 spaces for YAML/Markdown, 4 spaces default)
  • Integrated editorconfig-checker into pre-commit hooks for automated enforcement
  • Simplified MSRV testing by consolidating separate check and test recipes into a single check command

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.editorconfig Expanded configuration with alphabetically sorted rules, added end_of_line enforcement, and file-type-specific indentation (YAML/Markdown: 2 spaces, LICENSE files: unset)
.pre-commit-config.yaml Added editorconfig-checker hook (v3.6.0) to automatically validate EditorConfig compliance
justfile Completed incomplete comment on line 3, removed separate check-msrv and test-msrv recipes in favor of simplified ci-test-msrv, and fixed shell block indentation in assert-git-is-clean to use consistent 4-space indentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +44 to +45
ci-test-msrv: env-info
cargo check --all-features --package {{main_crate}}
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MSRV verification has been significantly simplified. The new implementation only checks compilation of the main crate library with all features, whereas the previous implementation checked all targets (including tests, benches, and examples via --all-targets) and ran tests across the workspace.

This means MSRV compatibility is no longer verified for:

  1. Test code, benchmarks, and examples (missing --all-targets)
  2. Runtime behavior (tests are no longer executed)

If this simplification is intentional, consider documenting the reasoning. Otherwise, consider restoring --all-targets at minimum, or test execution if runtime MSRV compatibility is important.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants