adding the parameter safe_domain in case there is a specific value#9
Open
gdraperi wants to merge 1 commit intonyxgeek:masterfrom
Open
adding the parameter safe_domain in case there is a specific value#9gdraperi wants to merge 1 commit intonyxgeek:masterfrom
gdraperi wants to merge 1 commit intonyxgeek:masterfrom
Conversation
Owner
|
I appreciate the PR! However I believe it may be unnecessary -- The safe_domain is derived directly from the -d parameter, but the periods are replaced with underscores. If you need a different 'safe_domain', simply change the -d parameter to the domain you would like it to use, BUT be sure to specify a tenant with -t so that it doesn't try to do autolookup. I see how that could cause confusion -- going to make a wiki to go over some use cases with examples. Could you give that a try and confirm if that works? Feel free to DM me (@nyxgeek on twitter) if you would be okay with sharing some specifics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had a situation where safe_domain was different from the tenant and the domain and I had to setup a specific value.
https://{self.tenant_name}-my.{self.endpoint}/personal/{safeusername}_{self.safe_domain}/_layouts/15/onedrive.aspx'
I added an option to specify it and in the default case it comes back to the domain value to generate the safe domain.