factor: switch to new bclibc universal curve build func

[o-murphy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the curve generation process by updating the bclibc dependency and refactoring the Python binding to utilize a newly introduced universal curve building function. This change centralizes the PCHIP interpolation logic, reducing code duplication and improving maintainability by relying on the core library for complex mathematical operations.

Highlights

• Dependency Update: The bclibc subproject has been updated to a newer commit (9dea71a).
• Code Refactoring: The BCLIBC_Curve_fromPylist function in py_bind.cpp was refactored to delegate PCHIP curve calculation to a new universal build function (build_pchip_curve_from_arrays) provided by the updated bclibc library.
• Reduced Code Duplication: Extensive PCHIP interpolation logic was removed from py_bind.cpp, centralizing the implementation within the bclibc core.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the bclibc subproject and refactors the BCLIBC_Curve_fromPylist function in py_bind.cpp. The PCHIP curve calculation logic has been extracted into a new build_pchip_curve_from_arrays function, streamlining BCLIBC_Curve_fromPylist to focus on Python data extraction and error handling. The review suggests considering re-adding a concise comment to clarify the robustness of the PyList_GetItem nullptr check for future maintainability.

I am having trouble creating individual review comments. Click here to see my feedback.

py_ballisticcalc.exts/py_ballisticcalc_exts/src/py_bind.cpp (138-139)

The removed comment provided valuable context regarding the robustness of the PyList_GetItem nullptr check, specifically that it's primarily for cases where the list size might change during iteration. While the check remains, losing this explanation might make the code slightly less clear for future maintainers unfamiliar with the nuances of the Python C API. Consider adding a concise comment to the new code if this context is deemed important for maintainability.