Address linting and formatting issues #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directcuteo
force-pushed
the
2173-address-linting-and-formatting
branch
from
adbbcd9 to
5853f71
Compare
directcuteo
force-pushed
the
2173-address-linting-and-formatting
branch
from
5853f71 to
870856c
Compare
directcuteo
force-pushed
the
2173-address-linting-and-formatting
branch
from
870856c to
3eb6213
Compare
directcuteo
force-pushed
the
2173-address-linting-and-formatting
branch
from
2c52234 to
d044165
Compare
- Add GitHub Actions CI workflows for build, lint, format, and Docker - Apply formatting and linting fixes across the codebase - Fix clippy zombie_processes lint for test compilation in ptrace-poc - Revert openmina dependency to compatible revision (6fb148ba) Co-Authored-By: Claude Opus 4.6 <[email protected]>
directcuteo
force-pushed
the
2173-address-linting-and-formatting
branch
from
d044165 to
e7120c5
Compare
Contributor
Author
|
issue here: o1-labs/mina-rust#2173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note on openmina revision change
The newer openmina revision (
ed6f4301) that was previously used in this branch contains code that referencesserde::__private, which is not available in serde 1.0.228. This is an upstream issue in the openmina repository, not an issue with this codebase.To unblock CI, we reverted to the same openmina revision used by
main(6fb148ba), which is compatible with our current dependencies.Test plan
make lintpassesmake check-formatpassesmake buildpasses