Add comprehensive unit tests for GCS storage provider#4
Open
SanabriaRusso wants to merge 4 commits intomainfrom
Open
Add comprehensive unit tests for GCS storage provider#4SanabriaRusso wants to merge 4 commits intomainfrom
SanabriaRusso wants to merge 4 commits intomainfrom
Conversation
SanabriaRusso
commented
Sep 4, 2025
SanabriaRusso
commented
- Add test dependencies (mockito, tokio-test) to Cargo.toml
- Implement unit tests for GCS provider operations and error scenarios
- Add storage factory integration tests
- Include bucket validation warnings as specified in CLAUDE.md
- Replace GCS_MIGRATION_PLAN.md with simplified STORAGE_BACKENDS.md documentation
- Document current implementation limitations and usage examples
SanabriaRusso
added
documentation
SanabriaRusso
force-pushed
the
gcs-test
branch
2 times, most recently
from
ed68b89 to
319e95f
Compare
Applied cargo fmt to resolve formatting issues in: - storage/gcs.rs: Fixed test code formatting and spacing - storage/factory.rs: Fixed test assertions and line breaks - vote.rs: Fixed import statement formatting - ledger.rs: Applied general formatting fixes - ranked_vote.rs: Applied general formatting fixes
SanabriaRusso
force-pushed
the
gcs-test
branch
from
319e95f to
29e1a5a
Compare
…_contain_helpful_context assertion to accept bucket configuration errors - Clean up 23 unused variable warnings in GCS test suite by prefixing with underscores - Remove unused Mock import, add #[allow] attributes for intentionally unused test code \ - Apply cargo fmt formatting fixes for nightly Rust compatibility
directcuteo
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.