CI: lint dockerfiles #1183
Merged
CI: lint dockerfiles #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
commented
Jul 16, 2025
| docker-build-test ## Build all Docker images | ||
|
|
||
| .PHONY: docker-build-bootstrap-sandbox | ||
| docker-build-bootstrap-sandbox: ## Build bootstrap sandbox Docker image |
There was a problem hiding this comment.
Even if this seems broken, removing it will be part of a follow-up PR.
dannywillems
force-pushed
the
dw/add-hadolint
branch
from
bc180b6 to
0e74271
Compare
dannywillems
commented
Jul 16, 2025
Makefile
Outdated
|
|
||
| .PHONY: docker-build-light | ||
| docker-build-light: ## Build light Docker image | ||
| docker build -t $(DOCKER_ORG)/openmina-light:$(GIT_COMMIT) -f node/testing/docker/Dockerfile.light node/testing/docker/ |
There was a problem hiding this comment.
This seems broken, but it will be fixed later. It is not part of this patch.
dannywillems
commented
Jul 16, 2025
| docker build -t $(DOCKER_ORG)/openmina-light:$(GIT_COMMIT) -f node/testing/docker/Dockerfile.light node/testing/docker/ | ||
|
|
||
| .PHONY: docker-build-light-focal | ||
| docker-build-light-focal: ## Build light focal Docker image |
There was a problem hiding this comment.
This seems broken, but it will be fixed later. It is not part of this patch.
dannywillems
commented
Jul 16, 2025
| docker build -t $(DOCKER_ORG)/openmina:$(GIT_COMMIT) . | ||
|
|
||
| .PHONY: docker-build-openmina-testing | ||
| docker-build-openmina-testing: ## Build OpenMina testing Docker image |
There was a problem hiding this comment.
This seems broken, but it will be fixed later. It is not part of this patch.
dannywillems
force-pushed
the
dw/add-hadolint
branch
from
0e74271 to
7bf5e53
Compare
dannywillems
commented
Jul 16, 2025
| -f node/testing/docker/Dockerfile.light node/testing/docker/ | ||
|
|
||
| .PHONY: docker-build-light-focal | ||
| docker-build-light-focal: ## Build light focal Docker image |
There was a problem hiding this comment.
This seems broken, but it will be fixed later. It is not part of this patch.
directcuteo
approved these changes
Jul 16, 2025
dannywillems
force-pushed
the
dw/unify-ci-makefile
branch
from
30c3aff to
0b2599c
Compare
- Reduces Docker image size by avoiding installation of recommended packages - Fixes hadolint DL3015 warnings across all Dockerfiles
- Added quotes around $(opam config env) in all Dockerfiles - Fixes hadolint SC2046 warnings for proper shell quoting - Affects tools/fuzzing, node/testing/docker, and producer-dashboard Dockerfiles
Issues Fixed: 1. DL3027 - Replaced apt with apt-get in tools/fuzzing/Dockerfile 2. SC2086 - Added double quotes around $ARCH variable in tools/fuzzing/Dockerfile 3. DL3059 - Consolidated consecutive RUN instructions in tools/fuzzing/Dockerfile 4. SC2174 - Fixed mkdir -p -m by separating into mkdir -p and chmod commands in tools/bootstrap-sandbox/Dockerfile 5. SC3046 - Replaced source with . in node/testing/docker/Dockerfile.test 6. DL3009 - Added missing rm -rf /var/lib/apt/lists/* cleanup in tools/fuzzing/Dockerfile
Updated the lint-dockerfiles target to: - Capture all hadolint output - Exit with code 1 if any warnings or errors are found - Work correctly in both GitHub Actions and local environments
dannywillems
force-pushed
the
dw/add-hadolint
branch
from
8209382 to
a0221d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1185
Fix #1184