Skip to content

Conversation

volhovm
Copy link
Contributor

@volhovm volhovm commented Jul 23, 2025

This adds a nix flake that is necessary to compile the project on nixos.

@volhovm volhovm force-pushed the volhovm/add-nix-flake branch from 25a0a4a to 3f35328 Compare July 23, 2025 13:58
@dannywillems
Copy link
Member

dannywillems commented Jul 23, 2025

Can we have an item in the CHANGELOG (a simple line would be good) as it might be interesting for users to see Nix support?

@volhovm volhovm marked this pull request as ready for review July 23, 2025 15:20
@volhovm volhovm force-pushed the volhovm/add-nix-flake branch from 3ce2791 to 7dc7470 Compare July 23, 2025 15:20
@volhovm volhovm enabled auto-merge July 23, 2025 15:56
@volhovm
Copy link
Contributor Author

volhovm commented Jul 24, 2025

@dannywillems I added it, rereview?

@volhovm volhovm force-pushed the volhovm/add-nix-flake branch from 7dc7470 to 745ff44 Compare July 24, 2025 12:18
@dannywillems
Copy link
Member

@dannywillems I added it, rereview?

Can you please add a test in the CI, as we do for macOS in #1247? Claude can be very helpful, I recommend you to use it to automate.
I would like us to be strict on new build systems added to the repository, and be sure we keep maintaining it. Adding a CI job testing it is the best way.

@volhovm volhovm force-pushed the volhovm/add-nix-flake branch 4 times, most recently from d644266 to 02bcac0 Compare July 24, 2025 17:03
@dannywillems
Copy link
Member

You can rebase on top of develop. MacOS and Ubuntu setups have been fixed.

@volhovm volhovm force-pushed the volhovm/add-nix-flake branch from 02bcac0 to 16aea28 Compare July 25, 2025 14:15
@volhovm volhovm force-pushed the volhovm/add-nix-flake branch 2 times, most recently from 35f63ef to 8375d0b Compare July 27, 2025 19:45
@volhovm volhovm force-pushed the volhovm/add-nix-flake branch from 8375d0b to aa49e60 Compare July 28, 2025 12:43
@volhovm volhovm merged commit 0242e27 into develop Jul 29, 2025
64 of 65 checks passed
@volhovm volhovm deleted the volhovm/add-nix-flake branch July 30, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants