-
Notifications
You must be signed in to change notification settings - Fork 40
CI: Support multi-platform builds and standardize test execution on ubuntu-latest #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d89602
to
3674f65
Compare
3674f65
to
65708ed
Compare
e9300de
to
2aac662
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables multi-platform builds for OpenMina CI and standardizes test execution on Ubuntu 24.04. The changes address issue #1179 by expanding platform support while maintaining consistent test environments.
- Added build matrix to support Ubuntu 22.04, Ubuntu 24.04 (x86_64 and ARM64), and macOS latest
- Standardized all test runners to use ubuntu-24.04 for consistency
- Updated documentation to reflect officially supported platforms
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
.github/workflows/ci.yaml |
Added matrix strategy for multi-platform builds and updated all test runners to ubuntu-24.04 |
website/docs/developers/getting-started.mdx |
Updated system requirements to reflect officially supported platforms with CI testing |
CLAUDE.md |
Added CHANGELOG guidelines for future contributions |
CHANGELOG.md |
Added entry documenting the CI platform support changes |
Comments suppressed due to low confidence (4)
.github/workflows/ci.yaml:123
- The runner 'ubuntu-24.04-arm' does not exist in GitHub Actions. The correct runner name for ARM64 Ubuntu is 'ubuntu-24.04-arm64'.
os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
.github/workflows/ci.yaml:167
- The runner 'ubuntu-24.04-arm' does not exist in GitHub Actions. The correct runner name for ARM64 Ubuntu is 'ubuntu-24.04-arm64'.
os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
.github/workflows/ci.yaml:209
- The runner 'ubuntu-24.04-arm' does not exist in GitHub Actions. The correct runner name for ARM64 Ubuntu is 'ubuntu-24.04-arm64'.
os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
.github/workflows/ci.yaml:258
- The runner 'ubuntu-24.04-arm' does not exist in GitHub Actions. The correct runner name for ARM64 Ubuntu is 'ubuntu-24.04-arm64'.
os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
Update CHANGELOG entry for PR #1249 to include GLIBC compatibility fix and update getting-started documentation to reflect that full test suite runs on ubuntu-22.04 for container compatibility.
Update CHANGELOG entry for PR #1249 to include GLIBC compatibility fix and update getting-started documentation to reflect that full test suite runs on ubuntu-22.04 for container compatibility.
9adf8e0
to
b8b1cec
Compare
No, it is ubuntu-24.04-arm |
- Add matrix strategy to build, build_wasm, build-tests, and build-tests-webrtc jobs - Support ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, and macos-latest - Add platform-specific dependency installation (apt vs brew) - Update artifact names to include OS identifier to avoid conflicts - Add documentation update reminders for platform matrix changes This enables testing builds across multiple platforms while maintaining the same functionality.
Document the CHANGELOG structure, entry format, and commit pattern for future contributors. Includes: - CHANGELOG sections (OCaml node, Added, Changed, Fixed, Dependencies) - Entry format with 80-character wrapping and PR references - Commit message pattern: 'CHANGELOG: add entry for patch XXXX' - Example entry from current PR This ensures consistent CHANGELOG maintenance across contributions.
Change test binary artifacts to be built on ubuntu-22.04 instead of ubuntu-24.04 to ensure GLIBC compatibility with the Debian Bullseye container used in scenario tests. This fixes "GLIBC_2.38/2.39 not found" errors when running scenario tests.
Update CHANGELOG entry for PR #1249 to include GLIBC compatibility fix and update getting-started documentation to reflect that full test suite runs on ubuntu-22.04 for container compatibility.
b8b1cec
to
8375e98
Compare
See individual commits
Fix #1179