Remove ocaml-interop dependency and associated FFI code #1256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the fork of
ocaml-interop
from sebastiencs and the associated FFI code as requested in the issue. Following @tizoc's comment that the dependency can be removed entirely as it's a remnant from very long ago, this change cleanly removes all OCaml interoperability code.Changes Made
Removed ocaml-interop dependency from
ledger/Cargo.toml
:Removed conditional FFI module from
ledger/src/lib.rs
:mod ffi;
declarationDeleted entire FFI directory
ledger/src/ffi/
:block.rs
- OCaml FFI bindings for block operationsdatabase.rs
- OCaml FFI bindings for database operationsmask.rs
- OCaml FFI bindings for mask operationsondisk.rs
- OCaml FFI bindings for ondisk operationsmod.rs
- FFI module declarationsVerification
ocaml-interop
feature is no longer availableThe removal is clean and safe since the FFI code was only conditionally compiled when the
ocaml-interop
feature was explicitly enabled, and the main codebase never relied on it.Fixes #3103671163.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.