Skip to content

Remove ocaml-interop dependency and associated FFI code #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 25, 2025

This PR removes the fork of ocaml-interop from sebastiencs and the associated FFI code as requested in the issue. Following @tizoc's comment that the dependency can be removed entirely as it's a remnant from very long ago, this change cleanly removes all OCaml interoperability code.

Changes Made

  1. Removed ocaml-interop dependency from ledger/Cargo.toml:

    • Removed the git dependency pointing to sebastiencs fork
    • Removed commented alternative dependencies
  2. Removed conditional FFI module from ledger/src/lib.rs:

    • Removed the feature-gated mod ffi; declaration
  3. Deleted entire FFI directory ledger/src/ffi/:

    • block.rs - OCaml FFI bindings for block operations
    • database.rs - OCaml FFI bindings for database operations
    • mask.rs - OCaml FFI bindings for mask operations
    • ondisk.rs - OCaml FFI bindings for ondisk operations
    • mod.rs - FFI module declarations

Verification

  • ✅ Build succeeds without the dependency
  • ✅ Tests continue to pass
  • ✅ The ocaml-interop feature is no longer available
  • ✅ No remaining references to ocaml-interop in the codebase
  • ✅ Code formatting and style checks pass

The removal is clean and safe since the FFI code was only conditionally compiled when the ocaml-interop feature was explicitly enabled, and the main codebase never relied on it.

Fixes #3103671163.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI changed the title [WIP] Remove fork of ocaml-interop from sebastiencs Remove ocaml-interop dependency and associated FFI code Jul 25, 2025
Copilot finished work on behalf of dannywillems July 25, 2025 12:39
@Copilot Copilot AI requested a review from dannywillems July 25, 2025 12:39
@dannywillems
Copy link
Member

Do not merge. This is a test.

@dannywillems dannywillems force-pushed the copilot/fix-1235 branch 2 times, most recently from 52e8ba9 to 3cd68b7 Compare July 25, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants