Unify the usage of Fp, Fq and curves by replacing mina_hasher::Fp with mina_curves::pasta::Fp #1269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where
mina_hasher::Fp
was being used inconsistently throughout the codebase whenmina_curves::pasta::Fp
should be used instead, creating unnecessary dependencies between crates.Changes Made
mina_hasher::Fp
withmina_curves::pasta::Fp
across 60+ filesmina_curves
dependency tocore
andnode
Cargo.toml files where neededFiles Updated
The changes span across multiple modules:
constants.rs
,network.rs
Verification
mina_hasher::Fp
references in codebaseThis refactoring eliminates redundant type usage and reduces inter-crate dependencies while maintaining full backward compatibility.
Fixes #1267.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.