-
Notifications
You must be signed in to change notification settings - Fork 40
Fix BP doc and add a CLI command to generate encrypted key #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce1e57f
to
ea8e66d
Compare
0d0a9ae
to
53266f8
Compare
136bcbe
to
abf448f
Compare
0xMimir
approved these changes
Aug 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9a05bb3
to
9b8f347
Compare
Mimicks secret_box in the Caml node
Use new encrypted key file generator
Replace broken intra-doc links to node::account::AccountSecretKey and p2p::identity::SecretKey with proper HTML links that work when building documentation in the full workspace context. This fixes documentation build failures when using -D warnings for broken links.
9b8f347
to
2341493
Compare
Changes only affecting docs. Bypassing the other jobs as unecessary if test-doc-commands work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for a description. They should be atomic.