Skip to content

CI: add timeout-minutes at different places #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2025
Merged

CI: add timeout-minutes at different places #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
440d3c2
CI: add timeout-minutes
dannywillems Aug 14, 2025
c6eac17
CI/docker: add timeout-minutes
dannywillems Aug 14, 2025
836889b
CI/lint: add timeout-minutes
dannywillems Aug 14, 2025
8855147
CI/whitespace-check: add timeout-minutes
dannywillems Aug 14, 2025
1f9c385
CI/build: add timeout-minutes 60
dannywillems Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ concurrency:

jobs:
ledger-tests:
timeout-minutes: 20
runs-on: ubuntu-24.04
steps:
- name: Git checkout
Expand Down Expand Up @@ -73,6 +74,7 @@ jobs:
run: make test-ledger

vrf-tests:
timeout-minutes: 8
runs-on: ubuntu-24.04
steps:
- name: Git checkout
Expand All @@ -94,6 +96,7 @@ jobs:
run: make test-vrf

p2p-tests:
timeout-minutes: 6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very short, can we make it 10minutes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can monitor https://github.com/o1-labs/openmina/actions/metrics/performance?tab=jobs&filters=workflow_file_name%3Aci.yaml.
I checked a few previous runs, and it seemed to be around 4-5 minutes.

runs-on: ubuntu-24.04
steps:
- name: Git checkout
Expand All @@ -112,6 +115,7 @@ jobs:
run: make test-p2p

build:
timeout-minutes: 60
# NOTE: If you add or remove platforms from this matrix, make sure to update
# the documentation at website/docs/developers/getting-started.mdx
strategy:
Expand Down Expand Up @@ -144,6 +148,7 @@ jobs:
retention-days: 7

build-wasm:
timeout-minutes: 60
# NOTE: If you add or remove platforms from this matrix, make sure to update
# the documentation at website/docs/developers/getting-started.mdx
strategy:
Expand All @@ -167,6 +172,7 @@ jobs:
run: make build-wasm

build-tests:
timeout-minutes: 60
# NOTE: If you add or remove platforms from this matrix, make sure to update
# the documentation at website/docs/developers/getting-started.mdx
strategy:
Expand Down Expand Up @@ -205,6 +211,7 @@ jobs:
retention-days: 7

build-tests-webrtc:
timeout-minutes: 60
# NOTE: If you add or remove platforms from this matrix, make sure to update
# the documentation at website/docs/developers/getting-started.mdx
strategy:
Expand Down Expand Up @@ -239,6 +246,7 @@ jobs:
p2p-scenario-tests:
needs: [ build-tests, build-tests-webrtc ]
runs-on: ubuntu-24.04
timeout-minutes: 20
container:
image: gcr.io/o1labs-192920/mina-daemon:3.2.0-beta2-939b08d-noble-devnet
options: --volume debugger_data:/tmp/db
Expand Down Expand Up @@ -298,6 +306,7 @@ jobs:
if: ${{ always() }}

scenario-tests:
timeout-minutes: 20
needs:
- build-tests
- build-tests-webrtc
Expand Down Expand Up @@ -384,6 +393,7 @@ jobs:
if: ${{ always() }}

record-replay-tests:
timeout-minutes: 30
needs:
- build-tests
- build-tests-webrtc
Expand Down Expand Up @@ -421,6 +431,7 @@ jobs:
./${{ matrix.test }} --test-threads=1

bootstrap-test:
timeout-minutes: 4
needs: [ build, build-tests ]
runs-on: ubuntu-24.04
env:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ env:

jobs:
build-openmina-node-image:
timeout-minutes: 40
strategy:
matrix:
arch:
Expand Down Expand Up @@ -63,6 +64,7 @@ jobs:

# Frontend
build-openmina-frontend-image:
timeout-minutes: 5
strategy:
matrix:
arch:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:

jobs:
lint:
timeout-minutes: 10
name: Lint - ${{ matrix.os }} - Rust ${{ matrix.toolchain }}
runs-on: ${{ matrix.os }}
strategy:
Expand Down Expand Up @@ -36,6 +37,7 @@ jobs:
DATABASE_URL: "sqlite:///tmp/heartbeats.db"

lint-tx-fuzzing:
timeout-minutes: 5
name: Lint transaction Fuzzing - ${{ matrix.os }} - Rust ${{ matrix.toolchain }}
runs-on: ${{ matrix.os }}
strategy:
Expand All @@ -56,6 +58,7 @@ jobs:
run: make check-tx-fuzzing

shellcheck:
timeout-minutes: 1
name: Shellcheck - ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
Expand All @@ -71,6 +74,7 @@ jobs:
run: make lint-bash

hadolint:
timeout-minutes: 1
name: Hadolint - ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/whitespace-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ on:

jobs:
check-whitespace:
timeout-minutes: 1
runs-on: ubuntu-22.04
steps:
- name: Checkout repository
uses: actions/checkout@v5

- name: Check for trailing whitespaces
run: make check-trailing-whitespace
run: make check-trailing-whitespace
Loading