Vendor num-bigint into num-bigint-generics #1379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/num-bigint-generics
branch
from
4277514 to
6a1d1b5
Compare
And tweak the lib file as `extern crate` is not idiomatic in the new edition.
dannywillems
force-pushed
the
dw/num-bigint-generics
branch
from
6a1d1b5 to
51e635a
Compare
dannywillems
force-pushed
the
dw/num-bigint-generics
branch
from
cc79719 to
8e6d756
Compare
dannywillems
force-pushed
the
dw/num-bigint-generics
branch
from
8e6d756 to
9393da4
Compare
|
Closing as #1383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library is from https://github.com/openmina/num-bigint/tree/1996d0807c31124315b93d009457716b61c6faab.
We want to get rid of forks, like
ark-ff,ark-ec,num-bigint, etc in #1367. The fork of num-bigint includes a parametrized version ofBigInt, which is not included in the original library. To avoid keeping multiple repositories over time, and have to go through different GitHub repositories, we suggest to vendor the library, and name it appropriately, coinednum-bigint-generic.