Skip to content

Ledger/transaction_logic: add fields doc #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

Ledger/transaction_logic: add fields doc #1494

merged 2 commits into from
Oct 7, 2025

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Oct 2, 2025 •
edited
Loading

This will be used in a next PR adding developers documentation about zkApps.

@dannywillems dannywillems requested a review from yamimaio October 2, 2025 15:45
@dannywillems dannywillems moved this to Done in Rust node Oct 2, 2025
@dannywillems dannywillems linked an issue Oct 2, 2025 that may be closed by this pull request
[Ledger App] Provide test vectors for signing zkApp #1409
Open
6 tasks
@dannywillems dannywillems force-pushed the dw/doc-transaction-logic branch 2 times, most recently from 327d0b8 to f2caae9 Compare October 2, 2025 16:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025 •
edited
Loading

⚠️ Code Reference Verification Failed

The documentation contains code references that do not match the current state of the codebase on the develop branch.

Issues Found

  • website/docs/developers/documentation-guidelines.md:38 - Code reference to ledger/src/scan_state/transaction_logic.rs#L3588-L3592 differs from GitHub (develop branch). The referenced code may have been modified locally but not yet merged to develop.

Action Required

The code referenced in the documentation must be merged to develop before documentation can be added/modified.

Please follow this workflow:

  1. Merge the code changes to develop first (this PR or a separate code PR)
  2. Create a follow-up PR with the documentation updates that reference the merged code
  3. The verification will pass once the code is available on develop

See the documentation guidelines for more information about the two-PR workflow.

@dannywillems dannywillems force-pushed the dw/doc-transaction-logic branch 3 times, most recently from 46d32a6 to 67ea4f4 Compare October 2, 2025 17:53
@dannywillems dannywillems force-pushed the dw/add-documentation-guidelines branch from ae10618 to 1e331ad Compare October 2, 2025 18:01
@dannywillems dannywillems changed the base branch from dw/add-documentation-guidelines to develop October 3, 2025 16:29
@dannywillems dannywillems force-pushed the dw/doc-transaction-logic branch from 67ea4f4 to 771cf9a Compare October 3, 2025 16:29
@dannywillems dannywillems force-pushed the dw/doc-transaction-logic branch from 771cf9a to d43bde4 Compare October 7, 2025 15:10
@dannywillems dannywillems merged commit 06a6855 into develop Oct 7, 2025
37 of 38 checks passed
@dannywillems dannywillems self-assigned this Oct 7, 2025
@dannywillems dannywillems deleted the dw/doc-transaction-logic branch October 16, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yamimaio yamimaio yamimaio approved these changes

Assignees

@dannywillems dannywillems

Labels

no changelog

Projects

Rust node
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Ledger App] Provide test vectors for signing zkApp

2 participants

@dannywillems @yamimaio