-
Notifications
You must be signed in to change notification settings - Fork 40
Website: use git grep to check OCaml ref + update absolute links #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dannywillems
merged 2 commits into
develop
from
dw/docs-check-ocaml-ref-use-absolute-link
Oct 13, 2025
Merged
Website: use git grep to check OCaml ref + update absolute links #1534
dannywillems
merged 2 commits into
develop
from
dw/docs-check-ocaml-ref-use-absolute-link
Oct 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCaml Reference Validation ResultsRepository: https://github.com/MinaProtocol/mina.git Click to see full validation output
|
✓ Code Reference Verification PassedAll code references in the documentation have been verified successfully! Total references checked: 1 The documentation is in sync with the codebase on the |
4b30914
to
76287c2
Compare
76287c2
to
a75bbc8
Compare
6 tasks
0xMimir
approved these changes
Oct 13, 2025
a75bbc8
to
f175b2e
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ripgrep was not working in the GH action. Locally, either by executing directly the script or by running
gh act
, the output of the bash script checking the OCaml refs was correctly working.Running with
set -euo pipefail
requires to rungit grep -l -E exp "**/*.rs"
, i.e. by surrounding with double quotes the pattern matching for the files, because we activated the strict mode for bash. In other words, runninggit grep -l -E exp **/*.rs
won't work.I'm suspecting an error in ripgrep, but I don't have time to investigate right now.