Skip to content

Conversation

dannywillems
Copy link
Member

The fp.rs file contained a custom field arithmetic implementation but was not integrated into the module system and had no imports or references in the codebase. This makes it dead code that can be safely removed.

The fp.rs file contained a custom field arithmetic implementation
but was not integrated into the module system and had no imports or
references in the codebase. This makes it dead code that can be safely
removed.
Copy link

github-actions bot commented Oct 13, 2025

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 992ac748ae16347460bd4d5859b0c8b5ce26e847

Validating references...
========================
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 992ac748ae16347460bd4d5859b0c8b5ce26e847)

Summary
=======
Total references found: 9
Valid references: 9
Invalid references: 0
Stale commits: 9

⚠ Warning: 9 reference(s) have stale commits
Run with --update to update them automatically

@dannywillems dannywillems moved this to Done in Rust node Oct 13, 2025
Copy link

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@dannywillems dannywillems linked an issue Oct 13, 2025 that may be closed by this pull request
6 tasks
@dannywillems dannywillems merged commit 8e05651 into develop Oct 13, 2025
60 of 61 checks passed
@dannywillems dannywillems deleted the remove-unused-poseidon-fp branch October 16, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Ledger App] Provide test vectors for signing zkApp

2 participants