Skip to content

Conversation

0xMimir
Copy link
Contributor

@0xMimir 0xMimir commented Oct 15, 2025

Closes #1464

Copy link

github-actions bot commented Oct 15, 2025

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: b4b10507c8ccbb5fa63d7c993530b96a9e4087a0)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

Copy link

github-actions bot commented Oct 15, 2025

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@0xMimir 0xMimir added the bug Something isn't working label Oct 15, 2025
@0xMimir 0xMimir force-pushed the bugfix/graphql-transaction branch 2 times, most recently from d359c5d to f6bf866 Compare October 15, 2025 12:25
@0xMimir 0xMimir requested a review from dannywillems October 15, 2025 12:31
@dannywillems dannywillems force-pushed the bugfix/graphql-transaction branch from d14f234 to ea1156d Compare October 15, 2025 14:16
@dannywillems
Copy link
Member

I ran the branch after rebasing on top of #1549, and it passes. Waitingo for 1549 to get merged, and I will rebase this one on top of develop right after.

@dannywillems dannywillems force-pushed the bugfix/graphql-transaction branch from 48169e4 to bd2304f Compare October 15, 2025 16:24
@dannywillems
Copy link
Member

Force merging as we are only interested in mina-node-native-tests

@dannywillems dannywillems merged commit aedace1 into develop Oct 15, 2025
48 checks passed
@dannywillems dannywillems deleted the bugfix/graphql-transaction branch October 16, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

GraphQL: errors when sending a transaction

2 participants