Consolidate build workflows #1562
+107
−335
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: Frontend CI Test | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| os: | ||
| description: 'OS to build on.' | ||
| required: false | ||
| default: 'ubuntu-24.04' | ||
| type: string | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ${{ github.event.inputs.os }} | ||
| steps: | ||
| - name: Echo | ||
| run: echo "Hello, world!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: Frontend CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, develop] | ||
| pull_request: | ||
| workflow_dispatch: | ||
| inputs: | ||
| os: | ||
| description: 'OS to build on. If empty, builds on all supported OSes.' | ||
| required: false | ||
| default: '' | ||
| type: string | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build: | ||
| strategy: | ||
| matrix: | ||
| os: ${{ github.event.inputs.os && fromJSON(format('["{0}"]', github.event.inputs.os)) || fromJSON('["ubuntu-22.04", "ubuntu-24.04-arm", "macos-13", "macos-14", "macos-15", "macos-latest"]') }} | ||
|
|
||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Git checkout | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Frontend build | ||
| uses: ./.github/actions/frontend-build | ||
| with: | ||
| test-build-commands: 'true' | ||
|
|
||
| lint-and-test: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - name: Git checkout | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Frontend build and test | ||
| uses: ./.github/actions/frontend-build | ||
| with: | ||
| run-prettier-check: 'true' | ||
| run-tests: 'true' | ||
| test-build-commands: 'false' | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of having separated files is to have different badges to add in the README: https://github.com/o1-labs/mina-rust?tab=readme-ov-file#supported-platforms. We can therefore see which platform is supported and the ones that are not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that really doesn't make sense that checks in a PR work on a job-by-job basis but status badges only work on a workflow by workflow basis. Let me see if there's another way to do this. It's a lot harder to get a complete picture of what's going on when only looking at the code if you have a bunch of different workflows all with the exact same trigger
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we can just use shields.io, it's free
https://img.shields.io/github/check-runs/o1-labs/mina-rust/rp/test-everything?nameFilter=deploy
I haven't quite figured out the naming (
deployworks, but I couldn't figure out the others), but I really don't think having a bunch of separate workflows is worth it just for the pretty badges