Fix TryFromIntError when deserializing P2P gossip messages with out-of-range nonce values

[Copilot]

Fix TryFromIntError when handling P2P gossip messages ✅

Issue Analysis

• Investigate the error: TryFromIntError when handling P2pNetworkPubsubIncomingMessage
• Identify root cause: binprot library reads integers as i64 and uses try_from to convert to target types
• Understand the problem: When binprot stream contains i64 values outside i32 range, conversion fails

Root Cause

The issue occurs in the Number<T> binprot reading implementation:

1. binprot_number!(u32, i32) macro reads an i32 from binprot then casts to u32
2. The binprot library's i32 reader first reads an i64, then uses try_from to convert to i32
3. If the i64 value is outside i32 range (< i32::MIN or > i32::MAX), try_from fails with TryFromIntError
4. This causes gossip message deserialization to fail

Solution Implemented ✅

• Implement custom binprot readers for Number<u32> and Number<u64> that read i64 directly
• Use wrapping cast for values outside the target range (avoids TryFromIntError)
• Maintain wire format compatibility by keeping original write implementations
• Add regression tests for edge cases (large i64, negative values)
• Verify all existing tests pass
• Add detailed documentation explaining intentional asymmetry
• Build verification (p2p and node packages compile successfully)
• Rebased onto develop branch

Design Decisions

The fix introduces intentional asymmetry between read and write:

• Reading: Accept any i64 value and cast using wrapping semantics for robustness
• Writing: Cast to signed type (may change sign bit) to maintain OCaml wire format compatibility
• This prevents connection drops from unexpected data while maintaining protocol compatibility

Testing ✅

• All existing mina-p2p-messages tests pass (85 tests)
• New tests verify fix handles i64 values outside i32 range
• New tests verify fix handles negative i64 values
• Wire format compatibility maintained (u32_max and u64_max tests pass)
• Tests pass after rebase to develop branch

Security Analysis ✅

• ✅ No memory safety issues - all operations on primitive types
• ✅ No integer overflow vulnerabilities - using well-defined wrapping casts
• ✅ No injection or data corruption issues - binary protocol handling
• ✅ Improved robustness - prevents denial of service from malformed data
• ✅ Maintains wire format compatibility - no breaking changes
• ✅ Fixed potential DoS where malformed messages could cause connection drops

Files Changed

• crates/p2p-messages/src/number.rs: Custom binprot implementations for Number and Number with comprehensive tests

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Failure when handling a P2P action - TryFromIntError</issue_title>
<issue_description>```
2025-08-21T13:59:52.199181Z ERROR node::reducer: time="1755784792113676093" summary="Failure when handling a P2P action" action_kind="P2pNetworkPubsubIncomingMessage" error=Invalid GossipNetMessageV2 message, error: TryFromIntError(TryFromIntError(()))

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

• Fixes Failure when handling a P2P action - TryFromIntError #1333

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[github-actions]

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ❌ Validation failed

Click to see full validation output

Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 75437cafea702d36865da779d43509c02d876f26

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 75437cafea702d36865da779d43509c02d876f26)
❌ INVALID: ledger/src/scan_state/transaction_logic/for_tests.rs
   Code at L:2285-2285 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2285-L2285
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2285-L2285
❌ INVALID: ledger/src/scan_state/transaction_logic/for_tests.rs
   Code at L:2351-2356 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2351-L2356
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2351-L2356
❌ INVALID: ledger/src/scan_state/transaction_logic/for_tests.rs
   Code at L:2407 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2407-L2407
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2407-L2407
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 75437cafea702d36865da779d43509c02d876f26)

Summary
=======
Total references found: 16
Valid references: 13
Invalid references: 3
Stale commits: 13

❌ Validation failed: 3 invalid reference(s) found

[github-actions]

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

[dannywillems]

@copilot rebase

[Copilot]

@copilot rebase

Successfully rebased onto develop branch (commits aae9cfa and 05355eb). The repository restructuring (mina-p2p-messages → crates/p2p-messages) was handled automatically by git during the rebase. All tests pass.

The rebased branch needs to be force-pushed to update the PR. The local branch is now based on develop@dd30271, but I'm unable to force-push directly. You may need to manually force-push or merge the changes.