test: add regression tests for salsa-simple#2102
Draft
dannywillems wants to merge 1 commit intodevelopfrom
Draft
test: add regression tests for salsa-simple#2102dannywillems wants to merge 1 commit intodevelopfrom
dannywillems wants to merge 1 commit intodevelopfrom
Conversation
OCaml Reference Validation ResultsRepository: https://github.com/MinaProtocol/mina.git Click to see full validation output |
✓ Code Reference Verification PassedAll code references in the documentation have been verified successfully! Total references checked: 1 The documentation is in sync with the codebase on the |
3 tasks
3 tasks
Add comprehensive regression tests for the salsa-simple XSalsa20 cipher implementation: - NaCl test vector verification with known expected keystream - Zero key/nonce test with reference implementation verification - Multi-block tests verifying counter increments correctly - Partial block handling tests with known expected values - Encrypt/decrypt roundtrip tests - Buffer size tests (1, 63, 64, 65, 127, 128, 129, 256, 1000 bytes) - Sequential vs bulk read comparison - Mixed size sequential read tests - Position tracking tests across block boundaries - Remaining bytes calculation tests - set_pos_unchecked method tests - check_remaining method tests - Distinct instance tests (same key/nonce produces same output) - Different key/nonce produces different output tests - Empty buffer edge case test - XOR property verification test Also fix zeroize dependency to include "derive" feature required for Zeroize and ZeroizeOnDrop derives.
dannywillems
force-pushed
the
add-salsa-simple-regtests
branch
from
10d1494 to
db81e3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive regression tests for the salsa-simple XSalsa20 cipher implementation:
Also fix zeroize dependency to include "derive" feature required for Zeroize and ZeroizeOnDrop derives.