Poseidon-arrays by richardpringle · Pull Request #2134 · o1-labs/mina-rust

richardpringle · 2026-02-02T15:54:42Z

This is a draft. Will edit soon

github-actions · 2026-02-02T15:55:04Z

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ❌ Validation failed

Click to see full validation output

Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412

Validating references...
========================
[OK] VALID: crates/ledger/src/account/account.rs:1266 -> src/lib/mina_base/account.ml L:201-224
  [WARN] STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic.rs:117 -> src/lib/mina_base/transaction_status.ml L:9-51
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic.rs:233 -> src/lib/mina_base/transaction_status.ml L:452-454
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic.rs:249 -> src/lib/mina_base/with_status.ml L:6-10
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic.rs:319 -> src/lib/mina_base/fee_transfer.ml L:76-80
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic.rs:344 -> src/lib/mina_base/fee_transfer.ml L:68-69
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic.rs:419 -> src/lib/mina_base/coinbase.ml L:17-21
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic.rs:1039 -> src/lib/transaction/transaction.ml L:8-11
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[ERROR] INVALID: crates/ledger/src/scan_state/transaction_logic/for_tests.rs:63
   Code at L:2285-2285 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2285-L2285
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2285-L2285
[ERROR] INVALID: crates/ledger/src/scan_state/transaction_logic/for_tests.rs:67
   Code at L:2351-2356 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2351-L2356
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2351-L2356
[ERROR] INVALID: crates/ledger/src/scan_state/transaction_logic/for_tests.rs:76
   Code at L:2407-2407 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2407-L2407
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2407-L2407
[OK] VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs:17 -> src/lib/mina_base/signed_command_payload.ml L:34-48
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs:43 -> src/lib/mina_base/stake_delegation.ml L:11-13
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs:70 -> src/lib/mina_base/signed_command_payload.ml L:179-181
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs:81 -> src/lib/mina_base/signed_command_payload.ml L:239-243
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[OK] VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs:112 -> src/lib/mina_base/signed_command_payload.ml L:352-362
  [WARN] STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)
[ERROR] INVALID: crates/p2p-messages/src/string.rs:14
   Code at L:140-140 differs between commit c0c9d702b8cba34a603a28001c293ca462b1dfec and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/c0c9d702b8cba34a603a28001c293ca462b1dfec/src/lib/mina_base/zkapp_account.ml#L140-L140
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/mina_base/zkapp_account.ml#L140-L140
[OK] VALID: crates/p2p-messages/src/string.rs:16 -> src/lib/mina_base/account.ml L:92-92
  [WARN] STALE COMMIT: c0c9d702b8cba34a603a28001c293ca462b1dfec (current: 96d469b19dc4bbc3f8d2a53e8c50f2cc99980412)

Summary
=======
Total references found: 18
Valid references: 14
Invalid references: 4
Stale commits: 14

[ERROR] Validation failed: 4 invalid reference(s) found

github-actions · 2026-02-02T15:55:43Z

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

richardpringle · 2026-02-02T15:58:14Z

crates/ledger/src/proofs/poseidon_params.rs

🤔 this is already in the mina-poseidon crate...

richardpringle · 2026-02-02T15:59:17Z

crates/ledger/src/proofs/transaction.rs

+    pub trait SpongeParamsForField<F: FieldWitness> {
+        fn get_params(is_legacy: bool) -> &'static SpongeParams<F>;
+    }


This could be a const

richardpringle · 2026-02-02T16:03:11Z

crates/snark/src/merkle_path/mod.rs

-
-        let expected_root_hash = LedgerHash::from_str(expected_root_hash).unwrap().0.clone();
-
-        assert_eq!(root_hash, expected_root_hash);


sus that this was deleted (the whole test that is)

richardpringle · 2026-02-02T16:03:52Z

crates/snark/src/lib.rs

 //!
 //! // Initialize SNARK state with configuration
-//! let config = SnarkConfig { /* ... */ };
+//! let config: SnarkConfig = todo!();


richardpringle · 2026-02-02T16:04:28Z

crates/vrf/src/lib.rs

    }

    #[test]
+    // #[ignore = "Runs long, remember to re-enable me!"]


Now remember to delete the comment

richardpringle · 2026-02-02T16:05:57Z

poseidon/src/lib.rs

There shouldn't be any changes in here, this whole file/crate should be deleted

richardpringle · 2026-02-02T16:06:21Z

POSEIDON_EXECUTION_PLAN.md

richardpringle · 2026-02-02T16:06:34Z

POSEIDON_MIGRATION_PLAN.md

crates/ledger/src/proofs/opt_sponge.rs

richardpringle · 2026-02-04T16:31:11Z

crates/ledger/src/proofs/opt_sponge.rs

 }

-fn block_cipher<F: FieldWitness>(
+fn block_cipher<F: FieldWitness + SpongeParamsForField<F>>(


And here... but does it make sense that this even has to be re-implemented?

richardpringle · 2026-02-04T16:32:31Z

crates/ledger/src/proofs/opt_sponge.rs

-    params: &SpongeParams<F>,
    w: &mut Witness<F>,
 ) {
+    let round_constants = &<F as SpongeParamsForField<F>>::get_params(false).round_constants;


This is odd. This is just a constant based on F. It should be a different generic argument, I would think, not a trait bound on F.

richardpringle · 2026-02-04T16:33:09Z

crates/ledger/src/proofs/opt_sponge.rs

-            .zip(params.mds[i].iter())
-            .fold(F::zero(), |x, (s, &m)| m * s + x)
-    })
+fn apply_mds_matrix<F: FieldWitness + SpongeParamsForField<F>>(state: &[F; 3]) -> [F; 3] {


This should already exist in mina_poseidon

richardpringle · 2026-02-04T16:33:45Z

crates/ledger/src/proofs/opt_sponge.rs

+
    for state_i in state.iter_mut() {
-        *state_i = sbox::<F>(*state_i);
+        *state_i = sbox(*state_i);


sbox should already exist in mina-poseidon. How is this different?

It's because of the witness

richardpringle · 2026-02-04T16:34:38Z

crates/ledger/src/proofs/step.rs

-    let xi_chal: [u64; 2] = sponge.squeeze_limbs();
-    let r_chal: [u64; 2] = sponge.squeeze_limbs();
+    let xi_chal: [u64; 2] = sponge.squeeze_limbs(2).try_into().unwrap();
+    let r_chal: [u64; 2] = sponge.squeeze_limbs(2).try_into().unwrap();


richardpringle · 2026-02-04T16:34:58Z

crates/ledger/src/proofs/step.rs


+fn to_fqs(fps: &[Fp]) -> Vec<Fq> {
+    fps.iter().map(|fp| Fq::from((*fp).into_bigint())).collect()
+}


...this is odd that we have to do this

richardpringle · 2026-02-04T21:20:43Z

crates/ledger/src/proofs/transaction.rs

+        pub fields: Vec<F>,
+        pub bits: Vec<bool>,


These probably shouldn't be pub

This is kind of crazy too. Can and should use bytemuck to do something more efficient

richardpringle · 2026-02-04T21:21:04Z

crates/ledger/src/proofs/transaction.rs

+                fields: Vec::with_capacity(256),
+                bits: Vec::with_capacity(512),


Comment on sizes here

richardpringle · 2026-02-17T21:10:34Z

crates/ledger/src/database/database.rs

I'm not sure where these hashes came with to begin with

richardpringle · 2026-02-17T21:10:52Z

crates/ledger/src/mask/mask_impl.rs

-            Unattached { hashes, .. } => hashes,
+            Root { database, .. } => return dbg!(database.get_cached_hash(addr)),
+            Attached { hashes, .. } => dbg!(hashes),
+            Unattached { hashes, .. } => dbg!(hashes),


richardpringle · 2026-02-17T21:23:55Z

crates/ledger/src/proofs/accumulator_check.rs

-        let of_coord =
-            |(x, y): &(BigInt, BigInt)| Ok(Vesta::of_coordinates(x.to_field()?, y.to_field()?));
+        let of_coord = |(x, y): &(BigInt, BigInt)| {
+            Vesta::of_coordinates(x.to_field::<Fq>(), y.to_field::<Fq>())


Fq can be inferred herer

richardpringle · 2026-02-17T21:25:25Z

crates/ledger/src/proofs/caching.rs

-    BigInt: From<&'a <G as AffineRepr>::ScalarField>,
-    BigInt: From<&'a <G as AffineRepr>::BaseField>,
+    BigInt: From<<G as AffineRepr>::ScalarField>,
+    BigInt: From<<G as AffineRepr>::BaseField>,


These are Copy types, we shouldn't be dealing with references here

richardpringle · 2026-02-17T21:29:12Z

crates/ledger/src/proofs/opt_sponge.rs

-fn block_cipher<F: FieldWitness>(
+fn block_cipher<F: FieldWitness + SpongeParamsForField<F>>(
    mut state: [F; M],
-    params: &SpongeParams<F>,


did I need this for Legacy-params?

richardpringle · 2026-02-17T21:36:14Z

crates/ledger/src/proofs/transaction.rs

-            number: number.to_ne_bytes(),
-        }
-        .take(NBITS)
+    pub fn bits_iter<N: Pod, const NBITS: usize>(number: &N) -> impl Iterator<Item = bool> + '_ {


Need to double check this

richardpringle · 2026-02-17T21:36:19Z

crates/ledger/src/proofs/transaction.rs


-    pub fn to_bits<N: Into<u64>, const NBITS: usize>(number: N) -> [bool; NBITS] {
-        let mut iter = bits_iter::<N, NBITS>(number);
+    pub fn to_bits<N: Pod, const NBITS: usize>(number: N) -> [bool; NBITS] {


richardpringle · 2026-02-17T21:55:43Z

crates/ledger/src/sparse_ledger/sparse_ledger_impl.rs


        for key in keys {
-            match BaseLedger::location_of_account(&ledger, key) {
+            match BaseLedger::location_of_account(&ledger, dbg!(key)) {


richardpringle · 2026-02-17T21:56:10Z

crates/ledger/src/sparse_ledger/sparse_ledger_impl.rs

Couple of dbg! statements that need to be deleted here

richardpringle · 2026-02-17T22:07:00Z

crates/p2p-messages/src/v2/hashing.rs

+        self.0.clone()
+    }
+    fn domain_string(_: ()) -> Option<String> {
+        Some("MinaProtoState".to_string())


Should use HashParam if it's accessible

richardpringle · 2026-02-17T22:09:06Z

crates/p2p-messages/src/v2/manual.rs

+                ROInput::new()
+            }
+            fn domain_string(_: ()) -> Option<String> {
+                Some("CoinbaseStack".to_string())


richardpringle · 2026-02-17T22:11:52Z

crates/p2p-messages/src/hash_input.rs

    test_to_field!(to_field_u64_test: append_u64(u64::MIN, u64::MAX/2, u64::MAX) = "ffffffffffffffffffffffffffffff7f00000000000000000000000000000000");
    test_to_field!(to_field_u48_test: append_u48(u48(u64::MIN), u48(u64::MAX/2), u48(u64::MAX)) = "ffffffffffffffffffffffff0000000000000000000000000000000000000000");
-    test_to_field!(to_field_bytes_test: append_bytes(&[0, 1, 255]) = "ff80000000000000000000000000000000000000000000000000000000000000");
+    test_to_field!(to_field_bytes_test: append_bytes_be(&[0, 1, 255]) = "ff80000000000000000000000000000000000000000000000000000000000000");


richardpringle · 2026-02-17T22:13:43Z

crates/p2p-messages/src/pseq.rs

PaddedSeq wraps an array, so we should just delegate to an array's Serialize and Deserialize implementations

richardpringle · 2026-02-17T22:14:33Z

crates/p2p-messages/src/pseq.rs

    where
        S: serde::Serializer,
    {
-        let mut serializer = serializer.serialize_tuple(N + 1)?;


No idea why the + 1 was here

richardpringle · 2026-02-17T22:15:43Z

crates/snark/src/merkle_path/mod.rs

+        inputs
+    }
+    fn domain_string(height: u32) -> Option<String> {
+        Some(format!("MinaMklTree{:03}", height))


Should use HashParam

richardpringle · 2026-02-17T22:16:28Z

crates/vrf/src/message.rs

+        self.0.clone()
+    }
+    fn domain_string(_: Self::D) -> Option<String> {
+        Some("MinaVrfMessage".to_string())


richardpringle · 2026-02-17T22:17:05Z

crates/vrf/src/message.rs

-    delegator_index: u64,
+    pub global_slot: u32,
+    pub epoch_seed: EpochSeed,
+    pub delegator_index: u64,


🤔 why are these pub?

richardpringle · 2026-02-17T22:18:04Z

crates/vrf/src/output.rs

-        inputs.append(x);
-        inputs.append(y);
+    fn domain_string(_: Self::D) -> Option<String> {
+        Some("MinaVrfOutput".to_string())


github-project-automation bot added this to Rust node Feb 2, 2026

richardpringle commented Feb 2, 2026

View reviewed changes

POSEIDON_EXECUTION_PLAN.md Outdated

Copy link
Copy Markdown

Collaborator Author

richardpringle Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete me

richardpringle commented Feb 2, 2026

View reviewed changes

POSEIDON_MIGRATION_PLAN.md Outdated

Copy link
Copy Markdown

Collaborator Author

richardpringle Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete me

richardpringle added 9 commits February 4, 2026 09:28

Simplify exports for poseidon package

5daebf9

Use modern module layout in mina-tree

6ab2c8d

WIP

8f1fced

more WIP

6f3c24a

Format

b48cb7d

did it do it

1c9d489

Formatting

9b09755

Update plan

84b6817

Another update

66d0efc

richardpringle force-pushed the rp/poseidon-arrays branch from dd96b2f to 66d0efc Compare February 4, 2026 14:31

richardpringle commented Feb 4, 2026

View reviewed changes

crates/ledger/src/proofs/opt_sponge.rs Show resolved Hide resolved

richardpringle commented Feb 4, 2026

View reviewed changes

richardpringle added 9 commits February 11, 2026 18:15

Don't copy poseidon directory

f8df3dc

Update tools/fuzzing

6856d01

Ignore tests with wrong hashes

bf65139

Sneak in PaddedSeq improvements

b13b71a

fixup! Sneak in PaddedSeq improvements

5e865ce

Remove unnecessary attribute

421da86

Put back the empty domain strings

5c1c6ab

Change expected database-hash values

24aad1b

Change expected hashes for mina-tree

2dd358c

richardpringle commented Feb 17, 2026

View reviewed changes

crates/ledger/src/database/database.rs

Copy link
Copy Markdown

Collaborator Author

richardpringle Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where these hashes came with to begin with

richardpringle commented Feb 17, 2026

View reviewed changes

richardpringle closed this Mar 30, 2026

github-project-automation bot moved this to Done in Rust node Mar 30, 2026

richardpringle mentioned this pull request Mar 31, 2026

Local poseidon crate from mina-rust consolidated into proof-systems #2054

Open


		let expected_root_hash = LedgerHash::from_str(expected_root_hash).unwrap().0.clone();

		assert_eq!(root_hash, expected_root_hash);

		fields: Vec::with_capacity(256),
		bits: Vec::with_capacity(512),

Conversation

richardpringle commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OCaml Reference Validation Results

Uh oh!

github-actions bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✓ Code Reference Verification Passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richardpringle Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 2, 2026 •

edited

Loading

github-actions bot commented Feb 2, 2026 •

edited

Loading

richardpringle Feb 2, 2026 •

edited

Loading