p2p: remove deprecated legacy WebRTC address format#2201
Open
iostat wants to merge 4 commits intoio/p2p-fix-identify-rejectfrom
Open
p2p: remove deprecated legacy WebRTC address format#2201iostat wants to merge 4 commits intoio/p2p-fix-identify-rejectfrom
iostat wants to merge 4 commits intoio/p2p-fix-identify-rejectfrom
Conversation
(#2074) Remove the fragile legacy /{peer_id}/{signaling_method}/... fallback from P2pConnectionOutgoingInitOpts::from_str. Only standard multiaddr format is now accepted. Restructure P2pConnectionOutgoingInitOptsParseError with typed variants (InvalidMultiaddr, InvalidMultiaddrStructure, InvalidPeerId) replacing the catch-all Other(String).
Remove deprecated legacy format section from webrtc.md and the legacy format mention from local-web-node-docker.mdx, matching the code removal in the previous commit.
OCaml Reference Validation ResultsRepository: https://github.com/MinaProtocol/mina.git Click to see full validation output |
✓ Code Reference Verification PassedAll code references in the documentation have been verified successfully! Total references checked: 1 The documentation is in sync with the codebase on the |
iostat
force-pushed
the
io/p2p-remove-legacy-multiaddr
branch
from
57b560c to
0dc9c49
Compare
This was referenced Mar 26, 2026
Remove FromStr implementations for SignalingMethod and HttpSignalingInfo that used fragile slash-delimited string parsing. These are no longer reachable from user input after the legacy address format removal, and were only used by custom Serialize/Deserialize impls. Switch to derived Serialize/Deserialize for SignalingMethod, HttpSignalingInfo, PathPrefix, and ProxyScheme.
iostat
force-pushed
the
io/p2p-remove-legacy-multiaddr
branch
from
0dc9c49 to
cf771bd
Compare
richardpringle
approved these changes
Mar 27, 2026
| ("/path", "https://example.com:443/path/mina/webrtc/signal"), | ||
| ("path/", "https://example.com:443/path/mina/webrtc/signal"), | ||
| ("/path/", "https://example.com:443/path/mina/webrtc/signal"), | ||
| ]; |
Collaborator
There was a problem hiding this comment.
Should use https://docs.rs/test-case/latest/test_case/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(stacked PRs: this is 2 of 3, merge #2200 first and then #2202 after)
Description
Remove the deprecated legacy WebRTC address format
(
/{peer_id}/{signaling_method}/...) and simplifyFromStrforP2pConnectionOutgoingInitOptsto only accept standard multiaddr. The legacyformat was deprecated with warnings in place; this completes the removal.
Also cleans up the error enum: replaces
NotEnoughArgs,PeerIdParseError,SignalingMethodParseError, and the catch-allOtherwith three specificvariants:
InvalidMultiaddr,InvalidMultiaddrStructure,InvalidPeerId.Related Issue(s)
Closes #2074
Type of Change
to not work as expected)
Testing
Changelog Entry
Removed: P2P: Deprecated legacy WebRTC address format (
/{peer_id}/{signaling}); only standard multiaddr is now accepted (#2201)