More powerful clippy lints #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
if possible I would skip build scripts too in addition to tests |
dkuehr
force-pushed
the
feat/more-powerfull-clippy
branch
from
27d7aec to
bf241c9
Compare
dkuehr
force-pushed
the
feat/more-powerfull-clippy
branch
from
bf241c9 to
307e516
Compare
tizoc
reviewed
Nov 8, 2024
| let consensus_state = v2::ConsensusProofOfStakeDataConsensusStateValueStableV2 { | ||
| blockchain_length: v2::UnsignedExtendedUInt32StableV1((pred_block.height() + 1).into()), | ||
| blockchain_length: v2::UnsignedExtendedUInt32StableV1( | ||
| (pred_block.height().saturating_add(1)).into(), |
Collaborator
There was a problem hiding this comment.
@dkuehr I am thinking if cases like these shouldn't be fatal failures. If this happens the state will be messed up and we cannot trust it, continuing as if nothing happened will just delay the error until later making things more confusing.
dkuehr
force-pushed
the
feat/more-powerfull-clippy
branch
from
307e516 to
60b6972
Compare
tizoc
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable more clippy lints to deal with potential panics