[DNM] move bindings to mina #2452
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/MinaProtocol/mina/pull/17887/files relevant PR in |
bleepbloopsify
force-pushed
the
leon/move-bindings-to-mina
branch
2 times, most recently
from
537ab69 to
3544640
Compare
(8f958aac99f53f27ce34e62861775d7117821a2c)` downgrades dune to 3.1 to be compatible upgrades node to 22.0 for wasm support (across our CI) nix rust toolchain upgrade to 2024-09-05 fixes API incompatibilities adds `.gitattributes` to some improper files fixes our `dune` files to have more standard flag usage (for better inheritance) adds a dependency debug line to a dune invocation in order to give better tracing for objects when building (doesn't affect happy path)
bleepbloopsify
force-pushed
the
leon/move-bindings-to-mina
branch
from
3544640 to
618bc9e
Compare
bleepbloopsify
force-pushed
the
leon/move-bindings-to-mina
branch
from
c2895d1 to
cb48b66
Compare
bleepbloopsify
force-pushed
the
leon/bump-mina
branch
5 times, most recently
from
5a4c740 to
1f78fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept branch:
delete all dune usage, and move all dune invocations to
mina.mina is on my personal branch,
leon/o1js-bindings.This allows us to remove
dunefromo1jsentirely.We'll have to carefully merge the
o1js_bindingsintominaand then make this change.I need to clean up the scripts as well.
Also, removed some logic around source maps, since it seems unused.