-
Notifications
You must be signed in to change notification settings - Fork 162
chore: break out wasm and JSOO builds #2546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e29afde
to
5eb6e2a
Compare
example output |
e01a3f7
to
fffb149
Compare
Shigoto-dev19
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run the scripts myself and I find it clearer and easier to follow than before. Well done 👏
Trivo25
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks clean!
1da14f5
to
8ce138e
Compare
8ce138e
to
e8ab8fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2368, #2369
adds
npm
targets:changes output permissions of artifacts from 777 to 660 as a general hygiene check
updates relevant scripts to use these npm targets rather than building as they see fit
removed some javascript based "copy" files and replaced them with bash statements in relevant locations. These should be replaced with
tsconfig
edits with time.notably: drops usage of
_node_bindings
in favor of usingnode_bindings
. There is no need for an intermediate "build" directory.ALSO: drops actual usage of
_node_bindings
as an import: it confuses the artifact generation process when there are two seemingly identical targets. this redirects imports tonode_bindings
, our actual usage._node_bindings
no longer exists after this PR is merged.PREBUILT_KIMCHI_BINDINGS_JS_WEB
was already left up todune
to handle. We invokeddune build
regardless of if this variable was set, and duplicated the functionality insidebash
anyways.I removed usage of it in
bash
in favor of keeping it indune
. This is to ensure that thenix
builds inmina
continue to work, regardless of ourbash
treatment of the variable.