(o1js) Native Prover with Napi - Verifier Index
#2658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querolita
requested review from
0x471 and
bleepbloopsify
and removed request for
a team
bleepbloopsify
approved these changes
Dec 3, 2025
Contributor
bleepbloopsify
left a comment
bleepbloopsify
left a comment
There was a problem hiding this comment.
If it works, it works, 🚢
Contributor
There was a problem hiding this comment.
This file is definitely a mouthful
I would probably look into code generation at around this point, maybe theres something we can make work here?
the as any truly makes me worry
Member
Author
There was a problem hiding this comment.
Yeah that's true. I would love to get type-safety here the same way the Wasm side does admit wasm-like types. I don't know what we can do at compile time though given that the backend is settled at runtime 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts upon the verifier index error that we obtained in the parent branch. It implements missing functions and types to enable the verifier index in the native prover. This PR (together with the proof-systems and mina counterparts) fixes errors derived from the ZkProgram compilation step. Meaning, the next error that is found already corresponds to the proof generation, which will be addressed in coming incremental PRs.
proof-systems side: o1-labs/proof-systems#3381
mina side: MinaProtocol/mina#18190
Closes #2527