[plonk_wasm] Don't pass around unnecessary vectors #3152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were manually creating vectors instead of using iterators and collect in the wasm code. This code should be more efficient
richardpringle
changed the title
7 tasks
Member
|
Waiting for #3157 to get merged to follow-up on this one. I'd like to be sure it does not break o1js. |
Contributor
Author
|
Update: I will get back to this when I have a chance, but please don't close in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying MinaProtocol/mina#16775 to
proof-systemssince the code movedManually allocating can potentially side-step a compiler optimization of re-using previous allocations where possible. Also, it's not a good practive to pass in a
Vecto a function where all you do with theVecis callas_slice. AVecconsists of a pointer, a length, and a capacity whereas a slice is only a pointer and a length. Slices should always be prefered when elements aren't being added or removed.