Skip to content

plonk-wasm: update warnings reg. base64 deprecated methods #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dannywillems wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Draft

plonk-wasm: update warnings reg. base64 deprecated methods #3163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plonk-wasm/src/pasta_fp_plonk_index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use ark_poly::EvaluationDomain;
use base64::{engine::general_purpose, Engine};
use kimchi::circuits::lookup::runtime_tables::RuntimeTableCfg;

use crate::{
Expand Down Expand Up @@ -270,7 +271,7 @@ pub fn caml_pasta_fp_plonk_index_write(
#[wasm_bindgen]
pub fn caml_pasta_fp_plonk_index_serialize(index: &WasmPastaFpPlonkIndex) -> String {
let serialized = rmp_serde::to_vec(&index.0).unwrap();
base64::encode(serialized)
general_purpose::STANDARD.encode(serialized)
}

// helpers
Expand Down
3 changes: 2 additions & 1 deletion plonk-wasm/src/pasta_fq_plonk_index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use ark_poly::EvaluationDomain;
use base64::{engine::general_purpose, Engine};
use kimchi::circuits::lookup::runtime_tables::RuntimeTableCfg;

use crate::{
Expand Down Expand Up @@ -269,5 +270,5 @@ pub fn caml_pasta_fq_plonk_index_write(
#[wasm_bindgen]
pub fn caml_pasta_fq_plonk_index_serialize(index: &WasmPastaFqPlonkIndex) -> String {
let serialized = rmp_serde::to_vec(&index.0).unwrap();
base64::encode(serialized)
general_purpose::STANDARD.encode(serialized)
}
3 changes: 2 additions & 1 deletion plonk-wasm/src/plonk_proof.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use crate::{
};
use ark_ec::AffineRepr;
use ark_ff::One;
use base64::{engine::general_purpose, Engine};
use core::{array, convert::TryInto};
use groupmap::GroupMap;
use kimchi::{
Expand Down Expand Up @@ -618,7 +619,7 @@ macro_rules! impl_proof {
pub fn serialize(&self) -> String {
let (proof, _public_input) = self.into();
let serialized = rmp_serde::to_vec(&proof).unwrap();
base64::encode(serialized)
general_purpose::STANDARD.encode(serialized)
}
}

Expand Down
Loading