Skip to content

fix: correct spelling errors in comments #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: correct spelling errors in comments #3336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e8c97
Update lookup_prover.rs
sashaodessa Sep 9, 2025
477b5e0
Update kzg.rs
sashaodessa Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions o1vm/src/pickles/lookup_prover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use kimchi::{circuits::domains::EvaluationDomains, curve::KimchiCurve, plonk_spo
use mina_poseidon::FqSponge;
use o1_utils::ExtendedDensePolynomial;
use poly_commitment::{commitment::absorb_commitment, ipa::SRS, OpenProof, SRS as _};
//TODO Parralelize
//TODO Parallelize
//use rayon::prelude::*;
use super::lookup_columns::{ELookup, LookupChallenges, LookupEvalEnvironment};
use crate::pickles::lookup_columns::*;
Expand Down Expand Up @@ -54,7 +54,7 @@ where
};

// Compute the 1/beta+sum_i gamma^i value_i for each lookup term
// The inversions is commputed in batch in the end
// The inversions is computed in batch in the end
let mut inverses: Vec<Vec<G::ScalarField>> = wires
.iter()
.zip(arity)
Expand Down Expand Up @@ -101,7 +101,7 @@ where
.interpolate()
};
let columns_poly = columns.my_map(interpolate_col);
// Commiting
// Committing
// TODO avoid cloning
let columns_com = columns_poly
.clone()
Expand All @@ -113,7 +113,7 @@ where
let columns_eval_d8 = columns_poly
.clone()
.my_map(|poly| poly.evaluate_over_domain_by_ref(domain.d8));
// abosrbing commit
// absorbing commit
// TODO don't absorb the wires which already have been
// TODO avoid cloning
columns_com
Expand Down
2 changes: 1 addition & 1 deletion poly-commitment/src/kzg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ impl<
.into_group();
let numerator_commitment = { poly_commitment - eval_commitment - blinding_commitment };
// We compute the result of the multiplication of two miller loop, to
// apply only one final exponentation
// apply only one final exponentiation
let to_loop_left = [
ark_ec::pairing::prepare_g1::<Pair>(numerator_commitment),
// Note that we do a neagtion here, to put everything on the same
Expand Down
Loading