feat: add no-std feature to poly-commitment crate #3418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add no-std support to poly-commitment with prover/verifier split: - SRS trait: verification methods available in no-std, prover methods (commit, mask, create, etc.) require std - OpenProof trait: verify method available in no-std, open method requires std - Feature-gate std-only modules: combine, utils, ipa, kzg, lagrange_basis, precomputed_srs, hash_map_cache, pbt_srs - Update commitment.rs: core types available in no-std, EndoCurve and multi_scalar_mul require std - Add poly-commitment to CI no-std workflow Fixes o1-labs/mina-rust#1990 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
no-stdfeature to poly-commitment with prover/verifier splitmax_poly_size,blinding_commitment,size) available in no-std, prover methods require stdverifymethod available in no-std,openmethod requires stdFixes o1-labs/mina-rust#1990
Test plan
cargo check -p poly-commitment --features no-std --no-default-featurespassescargo check -p poly-commitmentpasses (std build)cargo clippypasses for both modes