mina-poseidon: add hash prefixes for domain separation#3498
Open
dannywillems wants to merge 2 commits intomasterfrom
Open
mina-poseidon: add hash prefixes for domain separation#3498dannywillems wants to merge 2 commits intomasterfrom
dannywillems wants to merge 2 commits intomasterfrom
Conversation
dannywillems
force-pushed
the
dw/hash-prefixes
branch
from
a59619e to
fbc882c
Compare
Comment on lines
+101
to
+127
| /// `merkle_tree(depth)` — produces `"MinaMklTree{depth:03}"` | ||
| /// padded to 20 bytes. | ||
| #[must_use] | ||
| pub fn merkle_tree(depth: u32) -> [u8; LENGTH_IN_BYTES] { | ||
| create(&format!("MinaMklTree{depth:03}")) | ||
| } | ||
|
|
||
| /// `coinbase_merkle_tree(depth)` — produces | ||
| /// `"MinaCbMklTree{depth:03}"` padded to 20 bytes. | ||
| #[must_use] | ||
| pub fn coinbase_merkle_tree(depth: u32) -> [u8; LENGTH_IN_BYTES] { | ||
| create(&format!("MinaCbMklTree{depth:03}")) | ||
| } | ||
|
|
||
| /// `zkapp_body(chain_name)` — produces | ||
| /// `"{chain_name}ZkappBody"` padded/truncated to 20 bytes. | ||
| #[must_use] | ||
| pub fn zkapp_body(chain_name: &str) -> [u8; LENGTH_IN_BYTES] { | ||
| create(&format!("{chain_name}ZkappBody")) | ||
| } | ||
|
|
||
| /// `signature_other(chain_name)` — produces | ||
| /// `"{chain_name}Signature"` padded/truncated to 20 bytes. | ||
| #[must_use] | ||
| pub fn signature_other(chain_name: &str) -> [u8; LENGTH_IN_BYTES] { | ||
| create(&format!("{chain_name}Signature")) | ||
| } |
Collaborator
There was a problem hiding this comment.
These should all also be constants. Why don't we just leave this for now, figure out the proper way to do things in mina-rust, then we can migrate that code over to proof-systems afterwards?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.