Conversation
Signed-off-by: Scott Stults <sstults@opensourceconnections.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current test loop fills the cache while it's less than the max, and then there are assertions that require the added amount to be greater than. When we happen to add exactly enough to the cache to equal the maximum then the loop exits but the assertions that the size is greater than the maximum are not valid.
The change just adds the equal condition to the loop so that when it exits we are sure that the amount added is greater than the maximum.
See opensearch-project/opensearch-learning-to-rank-base#248