Improve performance of ratings in JSON #954
Conversation
| class UpdateQueryUpdatedAtWithRatings < ActiveRecord::Migration[7.1] | ||
| def change | ||
| execute <<-SQL | ||
| UPDATE queries SET updated_at = GREATEST(updated_at, (SELECT MAX(updated_at) FROM ratings WHERE query_id = queries.id)) |
There was a problem hiding this comment.
Alternatively a new column could be added like ratings_updated_at
|
How about we go through this next Ruby Code Jam??? It hink it could be great! |
|
@reid-rigo could we jump on a zoom and go through this.. I think my understanding has finally caught up enough over the past year to have a reaosnable conversation about this PR! We recently moved a lot of stuff to allow Quepid to have a case with 5000 queries (previosu feasible limit was like 300 or 500) and so I suspect this could help with some of the remaining bottle necks. |
|
@epugh yeah let's chat about it. I'll see if I can refresh my memory |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please do advocate for this issue and ideally submit a patch to get the attention of the maintainers! |
2 participants
Description
Case.includes(queries: :ratings)is a heavy operation for large cases.This optimizes JSON building with a method (
Case#doc_ratings_by_query) to load just the needed ratings columns in one shot.