-
Notifications
You must be signed in to change notification settings - Fork 25
fix: handling various linter warnings #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukasz-hycom
wants to merge
14
commits into
main
Choose a base branch
from
fix/handling-various-linter-warnings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
749a9a3
refactor: fixing "Avoid constructing JSX within try/catch" warning in…
lukasz-hycom 7b7901a
Merge branch 'main' of https://github.com/o2sdev/openselfservice into…
lukasz-hycom 6a3fc8a
refactor: simplify Renderer component by removing unused props
lukasz-hycom 6661f6a
refactor: remove unused Container import from InvoiceList and TicketR…
lukasz-hycom ef535e1
refactor: add comments to prevent linter warnings in CustomSurveyQues…
lukasz-hycom d7ce619
Merge branch 'main' of https://github.com/o2sdev/openselfservice into…
lukasz-hycom d033249
chore: update package-lock.json
lukasz-hycom 1a2bb0f
chore: update linting configurations and clean up code
lukasz-hycom 4b4d706
Merge branch 'main' of https://github.com/o2sdev/openselfservice into…
lukasz-hycom 8b0e384
fix: added proper `data` typing
marcinkrasowski 9fc66e6
fix: reverted eslint change to not allow any warnings
marcinkrasowski b78d54d
fix: improved type imports
marcinkrasowski a16f6b2
Merge remote-tracking branch 'origin/main' into fix/handling-various-…
marcinkrasowski e65d612
Merge remote-tracking branch 'origin/main' into fix/handling-various-…
marcinkrasowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| '@o2s/blocks.featured-service-list': patch | ||
| '@o2s/blocks.feature-section-grid': patch | ||
| '@o2s/blocks.notification-details': patch | ||
| '@o2s/blocks.notification-summary': patch | ||
| '@o2s/blocks.notification-list': patch | ||
| '@o2s/blocks.payments-history': patch | ||
| '@o2s/blocks.payments-summary': patch | ||
| '@o2s/blocks.feature-section': patch | ||
| '@o2s/blocks.pricing-section': patch | ||
| '@o2s/blocks.service-details': patch | ||
| '@o2s/blocks.article-search': patch | ||
| '@o2s/blocks.orders-summary': patch | ||
| '@o2s/blocks.ticket-details': patch | ||
| '@o2s/blocks.ticket-summary': patch | ||
| '@o2s/blocks.category-list': patch | ||
| '@o2s/blocks.document-list': patch | ||
| '@o2s/blocks.media-section': patch | ||
| '@o2s/blocks.order-details': patch | ||
| '@o2s/blocks.surveyjs-form': patch | ||
| '@o2s/blocks.ticket-recent': patch | ||
| '@o2s/configs.integrations': patch | ||
| '@o2s/blocks.article-list': patch | ||
| '@o2s/blocks.hero-section': patch | ||
| '@o2s/blocks.invoice-list': patch | ||
| '@o2s/blocks.product-list': patch | ||
| '@o2s/blocks.service-list': patch | ||
| '@o2s/blocks.user-account': patch | ||
| '@o2s/blocks.cta-section': patch | ||
| '@o2s/blocks.quick-links': patch | ||
| '@o2s/blocks.ticket-list': patch | ||
| '@o2s/blocks.bento-grid': patch | ||
| '@o2s/blocks.order-list': patch | ||
| '@o2s/modules.surveyjs': patch | ||
| '@o2s/blocks.category': patch | ||
| '@o2s/blocks.article': patch | ||
| '@o2s/blocks.faq': patch | ||
| --- | ||
|
|
||
| reworked data fetching a little to overcome ESlint warnings | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { config } from '@o2s/eslint-config/frontend'; | ||
|
|
||
| /** @type {import("eslint").Linter.Config} */ | ||
| export default [ | ||
| ...config, | ||
| { | ||
| rules: { | ||
| // Disable Next.js image rule since Docusaurus doesn't use next/image | ||
| '@next/next/no-img-element': 'off', | ||
| // Allow unescaped entities (apostrophes) in documentation text | ||
| 'react/no-unescaped-entities': 'off', | ||
| // Allow require() imports (Docusaurus may need them) | ||
| '@typescript-eslint/no-require-imports': 'off', | ||
| // Allow unused vars if they start with underscore | ||
| '@typescript-eslint/no-unused-vars': [ | ||
| 'warn', | ||
| { | ||
| argsIgnorePattern: '^_', | ||
| varsIgnorePattern: '^_', | ||
| caughtErrorsIgnorePattern: '^_', | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
apps/docs/src/components/HomepageArchitectureSection/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.