Fix: Added compatibility for gnome 48. #360
Conversation
|
This doesn't seem right, as modalDialog from gnome-shell is not exported as default, but as member, and the types also say, that it is correct, like it is. I also tested it with gnome-48 from ubuntu, and it works as expected. |
|
i was looking if i was the only with gnome 48 incompatibility, this proyect just sees so cool. is there a way to use this version? im noob jeje |
yeah, even CI error said so. |
weierophinney
left a comment
There was a problem hiding this comment.
I got this patch working by making the change suggested, and also updating the @girs/gnome-shell dependency to 48.0.4.
| import type { ExtensionBase } from '@girs/gnome-shell/dist/extensions/sharedInternals'; | ||
| import { MessageDialogContent } from '@girs/gnome-shell/dist/ui/dialog'; | ||
| import { ModalDialog } from '@girs/gnome-shell/dist/ui/modalDialog'; | ||
| import ModalDialog from '@girs/gnome-shell/dist/ui/modalDialog'; |
There was a problem hiding this comment.
| import ModalDialog from '@girs/gnome-shell/dist/ui/modalDialog'; | |
| import { ModalDialog } from '@girs/gnome-shell/dist/ui/modalDialog'; |
That module exports a number of different items, but no default export.
Pull Request Template
Description
Without this change, the extension is not working properly on Gnome 48. I tested it on Gnome 48 Manjaro.
Type of change
Checklist